Asset Hierarchy - Remove single partition deletion flag #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmivankov
reviewed
Nov 2, 2023
| @@ -21,8 +21,7 @@ final case class RelationConfig( | |||
| deleteMissingAssets: Boolean, | |||
| subtrees: AssetSubtreeOption, | |||
| ignoreNullFields: Boolean, | |||
| rawEnsureParent: Boolean, | |||
| enableSinglePartitionDeleteAssetHierarchy: Boolean // flag to test whether single partition helps avoid NPE in asset hierarchy builder | |||
There was a problem hiding this comment.
I think we might want to keep it for potential future investigations if we see weird NPEs again, that be a way to get one of them ready
There was a problem hiding this comment.
Ah fair enough, I'll rename it to "useSinglePartition" or something
dmivankov
reviewed
Nov 2, 2023
| @@ -22,7 +22,7 @@ final case class RelationConfig( | |||
| subtrees: AssetSubtreeOption, | |||
| ignoreNullFields: Boolean, | |||
| rawEnsureParent: Boolean, | |||
| enableSinglePartitionDeleteAssetHierarchy: Boolean // flag to test whether single partition helps avoid NPE in asset hierarchy builder | |||
| useSinglePartition: Boolean // a flag for helping to test NPEs by moving the data frame to a single partition | |||
There was a problem hiding this comment.
Suggested change
| useSinglePartition: Boolean // a flag for helping to test NPEs by moving the data frame to a single partition | |
| useSinglePartitionForAssetHierarchyDeletion: Boolean // a flag for helping to test NPEs by moving the data frame to a single partition |
or something. Maybe invert the name so that default values is false and it'd mean do repartition to 1. Also let's use repartition as default here
dmivankov
reviewed
Nov 2, 2023
| val enableSinglePartitionDeleteAssetHierarchy = | ||
| toBoolean(parameters, "enableSinglePartitionDeleteHierarchy", defaultValue = false) | ||
| val userSinglePartition = | ||
| toBoolean(parameters, "useSinglePartition", defaultValue = false) |
There was a problem hiding this comment.
Suggested change
| toBoolean(parameters, "useSinglePartition", defaultValue = false) | |
| toBoolean(parameters, "useSinglePartition", defaultValue = true) |
dmivankov
reviewed
Nov 2, 2023
| val enableSinglePartitionDeleteAssetHierarchy = | ||
| toBoolean(parameters, "enableSinglePartitionDeleteHierarchy", defaultValue = false) | ||
| val userSinglePartition = | ||
| toBoolean(parameters, "useSinglePartition", defaultValue = false) |
There was a problem hiding this comment.
Suggested change
| toBoolean(parameters, "useSinglePartition", defaultValue = false) | |
| toBoolean(parameters, "useSinglePartitionForAssetHierarchyDeletes", defaultValue = true) |
not sure about the name...
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #859 +/- ##
==========================================
+ Coverage 78.77% 78.79% +0.01%
==========================================
Files 48 48
Lines 3020 3018 -2
Branches 135 131 -4
==========================================
- Hits 2379 2378 -1
+ Misses 641 640 -1
|
|
This pull request seems a bit stale.. Shall we invite more to the party? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPE fixed with single partition deletes so move to that