fix(Group): explicitly define sourceId for all group variants (#1084)

cognitedata · Apr 11, 2024 · 220b7c1 · 220b7c1
1 parent d599890
commit 220b7c1
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/packages/stable/src/types.ts b/packages/stable/src/types.ts
@@ -1403,6 +1403,14 @@ export interface ManagedExternallyGroup extends BaseGroup {
 
 export interface ManagedInCDFGroup extends BaseGroup {
   members: GroupMembers;
+  // We are adding `sourceId: undefined` because this code:
+  // const foo(bar: Group) => console.log(bar.sourceId)
+  // yields the error:
+  // `Property 'sourceId' does not exist on type 'ManagedInCDFGroup'.`
+  // The Group type is defined as `type Group = ManagedInCDFGroup | ManagedExternallyGroup`
+  // and `sourceId` isn't defined on `ManagedInCDFGroup`.
+  // Typescript fails even though `sourceId` is an optional field on `ManagedExternallyGroup`.
+  sourceId: undefined;
 }
 
 export type Group = ManagedInCDFGroup | ManagedExternallyGroup;