fix: make unreliable AssetMapping fields optional (#1029)

* fix: make fields with unreliable existence optional * test: update test --------- Co-authored-by: Fredrik Anfinsen <[email protected]>
cognitedata · Sep 18, 2024 · 5e97292 · 5e97292
1 parent ba561d7
commit 5e97292
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/stable/src/__tests__/api/assetMappings3D.int.spec.ts b/packages/stable/src/__tests__/api/assetMappings3D.int.spec.ts
@@ -109,6 +109,10 @@ describe.skip('AssetMappings3D integration test', () => {
   });
 
   test('filter with treeIndexes filter succeeds', async () => {
+    if (assetMapping.treeIndex === undefined) {
+      throw Error('Asset mapping tree index was undefined');
+    }
+
     const response = await client.assetMappings3D.filter(
       model.id,
       revision.id,

diff --git a/packages/stable/src/types.ts b/packages/stable/src/types.ts
@@ -372,12 +372,14 @@ export interface AssetMapping3D extends AssetMapping3DBase {
   /**
    * A number describing the position of this node in the 3D hierarchy, starting from 0.
    * The tree is traversed in a depth-first order.
+   * Only present if the asset mapping's node ID is valid.
    */
-  treeIndex: number;
+  treeIndex?: number;
   /**
    * The number of nodes in the subtree of this node (this number included the node itself).
+   * Only present if the asset mapping's node ID is valid.
    */
-  subtreeSize: number;
+  subtreeSize?: number;
 }
 
 export interface AssetMapping3DBase {