-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup in concurrency module and typing #1173
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
- Coverage 90.14% 90.02% -0.12%
==========================================
Files 83 83
Lines 9743 9709 -34
==========================================
- Hits 8783 8741 -42
- Misses 960 968 +8
|
This will raise when passed a function with a named argument Ref.: if "priority" in inspect.signature(fn).parameters:
raise TypeError(f"Given function {fn} cannot accept reserved parameter name `priority`") |
That's fine. |
I think we should make it easier for SDK developers on On this branch with ...same with ...btw, I see that I've introduced this on |
Just linking issue here: #1168 |
I also think it's fine to require contributors to use python 3.8. But let's deal with this in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable 😉
0f3148c
to
75ff5ad
Compare
75ff5ad
to
1fd76e0
Compare
Description
Please describe the change you have made.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.