Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence Update Issue #2064

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Sequence Update Issue #2064

merged 7 commits into from
Dec 17, 2024

Conversation

doctrino
Copy link
Contributor

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@doctrino doctrino marked this pull request as ready for review December 14, 2024 06:48
@doctrino doctrino requested review from a team as code owners December 14, 2024 06:48
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.49%. Comparing base (458fe0f) to head (e733484).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/client/_api/sequences.py 89.09% 6 Missing ⚠️
cognite/client/_api_client.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2064      +/-   ##
==========================================
- Coverage   90.50%   90.49%   -0.01%     
==========================================
  Files         141      141              
  Lines       22533    22556      +23     
==========================================
+ Hits        20393    20412      +19     
- Misses       2140     2144       +4     
Files with missing lines Coverage Δ
cognite/client/_api/annotations.py 95.65% <100.00%> (ø)
cognite/client/_api/hosted_extractors/sources.py 94.02% <100.00%> (ø)
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/_api_client.py 90.34% <25.00%> (ø)
cognite/client/_api/sequences.py 94.89% <89.09%> (-0.33%) ⬇️

... and 1 file with indirect coverage changes

@haakonvt haakonvt force-pushed the introduced-issue-sequence-update branch from 76b436a to e733484 Compare December 17, 2024 10:56
Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doctrino doctrino enabled auto-merge (squash) December 17, 2024 10:59
@doctrino doctrino merged commit b141534 into master Dec 17, 2024
16 checks passed
@doctrino doctrino deleted the introduced-issue-sequence-update branch December 17, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants