Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version checker #2080

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Fix version checker #2080

merged 6 commits into from
Jan 6, 2025

Conversation

haakonvt
Copy link
Contributor

@haakonvt haakonvt commented Jan 6, 2025

After version 5.3.1, a hyphen in the package name became an underscore, and thus the regex stopped working.

This PR fixes the regex and removes all code related to manually parsing versions.

@haakonvt haakonvt requested review from a team as code owners January 6, 2025 11:09
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 8.69565% with 21 lines in your changes missing coverage. Please review.

Project coverage is 90.61%. Comparing base (49c87bd) to head (30eff37).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/client/utils/_version_checker.py 0.00% 19 Missing ⚠️
cognite/client/config.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2080      +/-   ##
==========================================
+ Coverage   90.49%   90.61%   +0.12%     
==========================================
  Files         141      141              
  Lines       22566    22516      -50     
==========================================
- Hits        20421    20403      -18     
+ Misses       2145     2113      -32     
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/utils/_auxiliary.py 96.64% <ø> (+3.56%) ⬆️
cognite/client/config.py 93.93% <33.33%> (+0.87%) ⬆️
cognite/client/utils/_version_checker.py 0.00% <0.00%> (-22.23%) ⬇️

... and 2 files with indirect coverage changes

@haakonvt haakonvt force-pushed the fix-version-checker branch from 08a3db2 to 2efb755 Compare January 6, 2025 11:22
@haakonvt haakonvt force-pushed the fix-version-checker branch 2 times, most recently from 53ce0e9 to c1425b2 Compare January 6, 2025 23:10
@haakonvt haakonvt force-pushed the fix-version-checker branch from c1425b2 to 9de76bc Compare January 6, 2025 23:24
@haakonvt haakonvt enabled auto-merge (squash) January 6, 2025 23:29
@haakonvt haakonvt merged commit cd4d2c2 into master Jan 6, 2025
16 checks passed
@haakonvt haakonvt deleted the fix-version-checker branch January 6, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants