Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency com.google.protobuf:protobuf-java to v4 #761

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 6, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
com.google.protobuf:protobuf-java major 3.25.3 -> 4.27.2

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

github-actions bot commented Jul 9, 2024

This pull request seems a bit stale.. Shall we invite more to the party?

@github-actions github-actions bot added the Stale label Jul 9, 2024
Copy link
Contributor Author

renovate bot commented Jul 19, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (a1c0ed7) to head (2aa1a33).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   84.67%   84.67%           
=======================================
  Files          96       96           
  Lines        2688     2688           
  Branches      235      235           
=======================================
  Hits         2276     2276           
  Misses        412      412           

@larshagencognite
Copy link
Contributor

@dmivankov thoughts on this? 4.28 and 4.29 came with backward compatibility fixes for files generated by <=3.25, and it looks like it works fine now

@dmivankov
Copy link
Contributor

Sounds fine, worst case downstream repos fail some test, or at least I hope they test it. Should mainly be for timeseries datapoints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants