-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file by instance id sdk support #799
base: master
Are you sure you want to change the base?
file by instance id sdk support #799
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #799 +/- ##
==========================================
- Coverage 84.82% 84.67% -0.16%
==========================================
Files 96 96
Lines 2676 2728 +52
Branches 204 189 -15
==========================================
+ Hits 2270 2310 +40
- Misses 406 418 +12
|
…te as that should be done via fdm
This pull request seems a bit stale.. Shall we invite more to the party? |
cogniteIds: Seq[CogniteIdOrInstanceId], | ||
ignoreUnknownIds: Boolean | ||
)(implicit itemsDecoder: Decoder[Items[R]]): F[Seq[R]] = | ||
requestSession.post[Seq[R], Items[R], ItemsWithIgnoreUnknownIds[CogniteIdOrInstanceId]]( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requestSession.post[Seq[R], Items[R], ItemsWithIgnoreUnknownIds[CogniteIdOrInstanceId]]( | |
requestSession.post[Seq[R], Items[R], ItemsWithIgnoreUnknownIds[InstanceId]]( |
still had a not on this method being called byInstanceIds but taking it CogniteIdOrInstanceId, should either be renamed or changed to accept according to name
This should allow file content support to use instance id instead of just external Id.
Note: update is also supported by instance id, and will only allow updates on the fields which cannot be set using fdm. This is to be done in another PR. It is not necessary for file content support, but might be for file support.