Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UP rule in ruff #416

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Enable UP rule in ruff #416

merged 2 commits into from
Jan 14, 2025

Conversation

mathialo
Copy link
Collaborator

@mathialo mathialo commented Jan 8, 2025

Also properly drop 3.9 support. #360 seems to have forgotten to edit the restriction in pyproject, just dropping testing for 3.9 (which will not work currently because of match statements).

Also properly drop 3.9 support. #360 seems to have forgotten to edit the
restriction in pyproject, just dropping testing for 3.9 (which will not
work currently because of match statements).
@mathialo mathialo requested a review from a team as a code owner January 8, 2025 13:17
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 88.54167% with 11 lines in your changes missing coverage. Please review.

Project coverage is 75.12%. Comparing base (e70f7ba) to head (0b09d32).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/extractorutils/statestore/hashing.py 50.00% 2 Missing ⚠️
...e/extractorutils/unstable/configuration/loaders.py 66.66% 2 Missing ⚠️
cognite/extractorutils/uploader/time_series.py 71.42% 2 Missing ⚠️
cognite/extractorutils/uploader_extractor.py 60.00% 2 Missing ⚠️
cognite/extractorutils/_inner_util.py 0.00% 1 Missing ⚠️
...xtractorutils/unstable/configuration/exceptions.py 50.00% 1 Missing ⚠️
cognite/extractorutils/unstable/core/runtime.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
+ Coverage   74.97%   75.12%   +0.14%     
==========================================
  Files          41       41              
  Lines        3409     3421      +12     
==========================================
+ Hits         2556     2570      +14     
+ Misses        853      851       -2     
Files with missing lines Coverage Δ
cognite/extractorutils/base.py 49.19% <100.00%> (+0.27%) ⬆️
cognite/extractorutils/configtools/_util.py 65.57% <100.00%> (+0.57%) ⬆️
cognite/extractorutils/configtools/elements.py 80.37% <100.00%> (ø)
cognite/extractorutils/configtools/loaders.py 83.78% <100.00%> (+0.07%) ⬆️
cognite/extractorutils/exceptions.py 77.77% <100.00%> (ø)
cognite/extractorutils/metrics.py 92.75% <100.00%> (+0.05%) ⬆️
cognite/extractorutils/statestore/watermark.py 92.76% <100.00%> (ø)
cognite/extractorutils/threading.py 78.94% <100.00%> (ø)
...te/extractorutils/unstable/configuration/models.py 86.00% <100.00%> (ø)
cognite/extractorutils/unstable/core/base.py 60.77% <100.00%> (ø)
... and 20 more

@mathialo mathialo merged commit e740773 into master Jan 14, 2025
5 checks passed
@mathialo mathialo deleted the up-ruff branch January 14, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants