Loosen dependency restriction on httpx #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `^0.x.y` in poetry is quite problematic, since it locks it to _minor_ version and only allows patch updates. This makes it very hard to depend on this package since it both makes it hard to update packages _and_ makes the likelihood of unresolvable requirements much higher. The same is really true for upper bounds in general, but to a lesser extent. There's a quite good blog post on it from one of the big guys in scientific python: https://iscinumpy.dev/post/bound-version-constraints/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
==========================================
- Coverage 75.00% 74.97% -0.03%
==========================================
Files 41 41
Lines 3409 3409
==========================================
- Hits 2557 2556 -1
- Misses 852 853 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
^0.x.yin poetry is quite problematic, since it locks it to minor version and only allows patch updates. This makes it very hard to depend on this package since it both makes it hard to update packages and makes the likelihood of unresolvable requirements much higher.The same is really true for upper bounds in general, but to a lesser extent. There's a quite good blog post on it from one of the big guys in scientific python:
https://iscinumpy.dev/post/bound-version-constraints/