Add option to set base url for custom deployment #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation provide only an option to specify the cluster name, parameterizing only that part of the URL and hard-coding the rest of the URL. This change add the option to specify a complete base URL and it tace precedence over the cluster name if specified In addtion to the new option to specify the base URL. There is a new option to add exter token custom arguments represented as comma-separated key-value pairs
|
This PR will cover PR #130 since I added the option to add any custom arguments with the request. |
BenChand
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation provide only an option to specify the cluster name, parameterizing only that part of the URL and hard-coding the rest of the URL.
This change add the option to specify a complete base URL and it tace precedence over the cluster name if specified
In addtion to the new option to specify the base URL. There is a new option to add exter token custom arguments represented as comma-separated key-value pairs