Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package version to metadata #45

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Dec 4, 2024

The package version is typically read during the augmentation phase, but this package doesn't have one (yet). Since the dependencies are already being read during identification, go ahead and read the version then as well.

Here's where this is populated for Python packages: https://github.com/colcon/colcon-core/blob/a74fa97fcea08d1e276a327228c119ce78aa0075/colcon_core/package_augmentation/python.py#L48-L50

The package version is typically read during the augmentation phase,
but this package doesn't have one (yet). Since the dependencies are
already being read during identification, go ahead and read the version
then as well.
@cottsay cottsay added the enhancement New feature or request label Dec 4, 2024
@cottsay cottsay self-assigned this Dec 4, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.21%. Comparing base (b12c637) to head (1b3f625).

Files with missing lines Patch % Lines
colcon_cargo/package_identification/cargo.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   67.09%   67.21%   +0.12%     
==========================================
  Files           6        6              
  Lines         234      241       +7     
  Branches       35       35              
==========================================
+ Hits          157      162       +5     
- Misses         55       57       +2     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cottsay cottsay merged commit 27c0b85 into main Dec 5, 2024
17 checks passed
@cottsay cottsay deleted the cottsay/version-metadata branch December 5, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants