Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify --target-dir to install operation #46

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Dec 5, 2024

This already gets passed to the 'build' operation, but is missing for 'install' resulting in a 'targets' subdirectory in the source tree.

This already gets passed to the 'build' operation, but is missing for
'install' resulting in a 'targets' subdirectory in the source tree.
@cottsay cottsay added the bug Something isn't working label Dec 5, 2024
@cottsay cottsay self-assigned this Dec 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.21%. Comparing base (27c0b85) to head (6cb73b4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files           6        6           
  Lines         241      241           
  Branches       35       35           
=======================================
  Hits          162      162           
  Misses         57       57           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works, thanks!

@luca-della-vedova luca-della-vedova merged commit 725167f into main Dec 5, 2024
17 checks passed
@luca-della-vedova luca-della-vedova deleted the cottsay/install-target-dir branch December 5, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants