Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for memberOfExternalDNs #101

Merged
merged 13 commits into from
Jun 11, 2020
Merged

support for memberOfExternalDNs #101

merged 13 commits into from
Jun 11, 2020

Conversation

jensens
Copy link
Member

@jensens jensens commented Apr 16, 2020

@jensens jensens marked this pull request as draft April 16, 2020 22:31
@jensens jensens force-pushed the memberOfExternalDNs branch 5 times, most recently from 780f0f8 to c2540a3 Compare April 17, 2020 00:17
@pbauer
Copy link
Member

pbauer commented Apr 17, 2020

Installation in a clean site still fails:

2020-04-17 10:25:09,503 ERROR   [Zope.SiteErrorLog:17][waitress] 1587111909.4970670.2567850304581484 http://localhost:8080/Plone2/acl_users/pasldap/manage_ldapplugin
Traceback (innermost last):
  Module ZPublisher.WSGIPublisher, line 156, in transaction_pubevents
  Module ZPublisher.WSGIPublisher, line 338, in publish_module
  Module ZPublisher.WSGIPublisher, line 248, in publish
  Module ZPublisher.mapply, line 85, in mapply
  Module Products.PDBDebugMode.wsgi_runcall, line 60, in pdb_runcall
  Module zope.browserpage.simpleviewclass, line 41, in __call__
  Module Products.Five.browser.pagetemplatefile, line 126, in __call__
  Module Products.Five.browser.pagetemplatefile, line 58, in __call__
  Module zope.pagetemplate.pagetemplate, line 133, in pt_render
  Module Products.PageTemplates.engine, line 88, in __call__
  Module z3c.pt.pagetemplate, line 173, in render
  Module chameleon.zpt.template, line 306, in render
  Module chameleon.template, line 209, in render
  Module chameleon.utils, line 75, in raise_with_traceback
  Module chameleon.template, line 187, in render
  Module ff21fd9ba7eee634f480c7d8e27f3ba2.py, line 417, in render
  Module pas.plugins.ldap.properties, line 87, in form
  Module yafowil.controller, line 18, in __init__
  Module yafowil.base, line 468, in extract
    yafowil widget processing info:
    - path      : ldapsettings
    - blueprints: ['form']
    - task      : extract
    - descr     : failed at 'form'
  Module yafowil.compound, line 24, in compound_extractor
  Module yafowil.base, line 468, in extract
    yafowil widget processing info:
    - path      : ldapsettings.users
    - blueprints: ['fieldset']
    - task      : extract
    - descr     : failed at 'fieldset'
  Module yafowil.compound, line 24, in compound_extractor
  Module yafowil.base, line 431, in extract
  Module yafowil.base, line 501, in _runpreprocessors
    yafowil widget processing info:
    - path      : ldapsettings.users.memberOfExternalDNs
    - blueprints: ['field', 'plonelabel', 'error', 'checkbox']
    - task      : run preprocessors
    - descr     : execute
  Module yafowil.yaml.parser, line 156, in fetch_value
<pre>expr:context.users.memberOfExternalDNs</pre>
  Module <string>, line 1, in <module>
AttributeError: 'UsersConfig' object has no attribute 'memberOfExternalDNs'

@rnixx
Copy link
Contributor

rnixx commented May 28, 2020

The relevant bits for this PR are merged in node.ext.ldap. Someone should fix travis and finish the work on this PR

@pbauer
Copy link
Member

pbauer commented May 28, 2020

@jensens flake8 correctly complains about your change in a150932#diff-201d2566640975dc9eb68ceecea6eb0bR97
Not sure what you did there 🤷‍♂️

@rnixx
Copy link
Contributor

rnixx commented May 28, 2020

Should be

logger.exception("Error in {0}".format(prefix))

then

versions.cfg Outdated Show resolved Hide resolved
@pbauer pbauer marked this pull request as ready for review May 29, 2020 08:04
Copy link
Contributor

@rnixx rnixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are the problems with fresh installation resolved?

CHANGES.rst Show resolved Hide resolved
TODO.rst Outdated Show resolved Hide resolved
src/pas/plugins/ldap/properties.yaml Outdated Show resolved Hide resolved
@rnixx rnixx merged commit 66c0e23 into master Jun 11, 2020
@rnixx rnixx deleted the memberOfExternalDNs branch June 11, 2020 05:44
@rnixx
Copy link
Contributor

rnixx commented Jun 11, 2020

Thanks for the work, I just dropped a 1.8.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants