Skip to content

Add description of macros and symlinks. #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2025

Conversation

jckirton
Copy link
Contributor

@jckirton jckirton commented Jul 5, 2025

Problem

There is no description of the ability for macros files to be symlinks.

@hmdunce
Copy link
Contributor

hmdunce commented Jul 5, 2025

Thanks!

I am a little wary of trying to document ln on the wiki, because it's platform specific, and because "PLEASE BACKUP..." is maybe not something you want to see on the wiki (?) 😅

Maybe we could make it more general? Explain macro files, just like you did, and mention that this means they can be copied or "symbolically linked" (link to https://en.wikipedia.org/wiki/Symbolic_link or whatever) using one's operating system, without trying to say exactly how to do that?

@seanmakesgames
Copy link
Member

I don't have write access on your fork's branch @jckirton, so wasn't able to push to it. Here's the patch I came up with though:
patchy.patch

you can apply to your branch with git apply: https://git-scm.com/docs/git-apply
I don't have time to troubleshoot why we can't push to PR requestor branches (I know there's an option for this) -- maybe someone like @hmdunce or @matr1x-hackmud can help figure it out?

@seanmakesgames
Copy link
Member

Oh and I added a section TODO for windows which should be filled out and tested before PR merge. 90+% of our players are on windows and windows apparently supports symlinks as of win10.

@hmdunce
Copy link
Contributor

hmdunce commented Jul 5, 2025

I don't have time to troubleshoot why we can't push to PR requestor branches (I know there's an option for this) -- maybe someone like @hmdunce or @matr1x-hackmud can help figure it out?

I also had this problem. Did you start your codespace from the PR by clicking "Review in codespace" or whatever? I haven't tested that yet.

@seanmakesgames
Copy link
Member

seanmakesgames commented Jul 5, 2025 via email

@hmdunce
Copy link
Contributor

hmdunce commented Jul 5, 2025

One workaround is to edit the files manually in the PR UI.


If we keep the ln stuff, maybe we should just write ln -s?

  1. It's POSIX (?)
  2. -f here means "delete the macros file" if it already exists
  3. -n shouldn't matter hopefully? 🤞

@seanmakesgames
Copy link
Member

Agree with ln -s -- but could also be done in another pr if there's a convo to be had about it.

@jckirton is there a setting somewhere that you have access to that can allow us to push to your branch? it would be something called like "allow maintainers push access" or something

worst case we'll use your workaround, dunce and just use the webui to modify

@hmdunce
Copy link
Contributor

hmdunce commented Jul 5, 2025

Sadly the author did check it it seems:

maintainers_are_allowed

(Maybe there is a better option too? 😄)

@jckirton
Copy link
Contributor Author

jckirton commented Jul 5, 2025

For now I have applied @seanmakesgames's patch as I like how it reads much better than what I originally had. I am always open and happy do discuss further.

As for the maintainers not being able to edit, I do have the only setting that appears to do that checked, so who knows why it wants to act up. ¯_(ツ)_/¯

CleanShot 2025-07-06 @ 0815@2x

@seanmakesgames
Copy link
Member

asked jibbity:

That error is expected behavior even with “allow edits by maintainers” checked — and here's why:

🧠 What's going on?
Codespaces are tied to your account's permissions, not the permissions of the GitHub Actions bot or GitHub's PR UI.

The “Allow edits by maintainers” checkbox only gives push access to users with write access to the base repo, but only through the GitHub web UI or via direct Git operations, not through Codespaces unless the Codespace is running in the context of the fork itself.

✅ What are your options?
Option 1: Use a local Git clone
If you:

Clone the fork locally (git clone https://github.com/jckirton/hackmud_wiki.git)

Add the upstream remote (git remote add upstream https://github.com/YOUR_ORG/hackmud_wiki.git)

Check out the PR branch

Make changes and push

You’ll be allowed to push changes, assuming you have push rights via the “edits by maintainers” setting.

Option 2: Use the GitHub Web Editor (not Codespaces)
Go to the fork via the web UI, and use GitHub's web-based file editor. It will let you push because you're authenticated and it respects the PR checkbox setting.

@kbinreallife kbinreallife merged commit 249f110 into comcode-org:main Jul 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants