-
Notifications
You must be signed in to change notification settings - Fork 34
Add description of macros and symlinks. #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! I am a little wary of trying to document Maybe we could make it more general? Explain macro files, just like you did, and mention that this means they can be copied or "symbolically linked" (link to https://en.wikipedia.org/wiki/Symbolic_link or whatever) using one's operating system, without trying to say exactly how to do that? |
I don't have write access on your fork's branch @jckirton, so wasn't able to push to it. Here's the patch I came up with though: you can apply to your branch with git apply: https://git-scm.com/docs/git-apply |
Oh and I added a section TODO for windows which should be filled out and tested before PR merge. 90+% of our players are on windows and windows apparently supports symlinks as of win10. |
I also had this problem. Did you start your codespace from the PR by clicking "Review in codespace" or whatever? I haven't tested that yet. |
Yep. That’s what I used
…On Sat, Jul 5, 2025 at 12:37 hmdunce ***@***.***> wrote:
*hmdunce* left a comment (comcode-org/hackmud_wiki#559)
<#559 (comment)>
I don't have time to troubleshoot why we can't push to PR requestor
branches (I know there's an option for this) -- maybe someone like
@hmdunce <https://github.com/hmdunce> or @matr1x-hackmud
<https://github.com/matr1x-hackmud> can help figure it out?
I also had this problem. Did you start your codespace from the PR by
clicking "Review in codespace" or whatever? I haven't tested that yet.
—
Reply to this email directly, view it on GitHub
<#559 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKWWGQY6FGF7GZJV73UWL3HASQFAVCNFSM6AAAAACA2WYY32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMZZG44TAMJQGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
One workaround is to edit the files manually in the PR UI. If we keep the
|
Agree with ln -s -- but could also be done in another pr if there's a convo to be had about it. @jckirton is there a setting somewhere that you have access to that can allow us to push to your branch? it would be something called like "allow maintainers push access" or something worst case we'll use your workaround, dunce and just use the webui to modify |
For now I have applied @seanmakesgames's patch as I like how it reads much better than what I originally had. I am always open and happy do discuss further. As for the maintainers not being able to edit, I do have the only setting that appears to do that checked, so who knows why it wants to act up. ¯_(ツ)_/¯ |
asked jibbity: That error is expected behavior even with “allow edits by maintainers” checked — and here's why: 🧠 What's going on? The “Allow edits by maintainers” checkbox only gives push access to users with write access to the base repo, but only through the GitHub web UI or via direct Git operations, not through Codespaces unless the Codespace is running in the context of the fork itself. ✅ What are your options? Clone the fork locally (git clone https://github.com/jckirton/hackmud_wiki.git) Add the upstream remote (git remote add upstream https://github.com/YOUR_ORG/hackmud_wiki.git) Check out the PR branch Make changes and push You’ll be allowed to push changes, assuming you have push rights via the “edits by maintainers” setting. Option 2: Use the GitHub Web Editor (not Codespaces) |
Problem
There is no description of the ability for macros files to be symlinks.