Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PlotJuggler with Rerun #32463

Open
2 tasks
adeebshihadeh opened this issue May 18, 2024 · 2 comments
Open
2 tasks

Replace PlotJuggler with Rerun #32463

adeebshihadeh opened this issue May 18, 2024 · 2 comments

Comments

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented May 18, 2024

We've got a proof of concept of https://rerun.io support in tools/rerun/. Rerun will support all the things we want out of a visualization tool. The first step is to replace PlotJuggler, which we mostly use for ad-hoc debugging. Once this is done, we can do cool things like showing all three cameras alongside your plots.

At a minimum, this means:

  • demo route fully loads in <10s
  • rerun runs smoothly (>30 fps). the POC seems to have a leak and it's 10 fps on my machine
  • can plot all the same things as PlotJuggler, with the same workflow
  • nice README, similar to PlotJuggler's

No comma account or device needed - just use the demo route. Community feedback/discussion is at https://github.com/commaai/openpilot/discussions/32419.


To reach parity with PlotJuggler, we'll need:


Relevant upstream Rerun issues:

@adeebshihadeh adeebshihadeh changed the title Replace PlotJuggler with Rerun [$750 bounty] Replace PlotJuggler with Rerun May 18, 2024
snigdha510 added a commit to snigdha510/openpilot that referenced this issue May 22, 2024
@adeebshihadeh adeebshihadeh pinned this issue May 22, 2024
@adeebshihadeh adeebshihadeh moved this from Open to Locked in openpilot bounties Jun 11, 2024
@adeebshihadeh adeebshihadeh changed the title [$750 bounty] Replace PlotJuggler with Rerun Replace PlotJuggler with Rerun Jul 7, 2024
@commaai commaai deleted a comment from mahdiait Jul 24, 2024
@adeebshihadeh
Copy link
Contributor Author

Locked to @bongbui321, pending Rerun https://github.com/rerun-io/rerun/milestone/30 due to perf issues in their current version

@sshane
Copy link
Contributor

sshane commented Aug 16, 2024

Some things I use quite often in PlotJuggler:

  • custom live functions (ability to reference multiple signals, time shift, etc)
  • layouts: save, load
  • toggle raw point dots easily
  • drag and drop
  • signal searching
  • easily manipulate plots: can add new signals on top or a new plot, split horizontally/vertically, zooming affects all plots at once, can see point values via scrub bar
  • better performance, rerun's UI runs at a lower FPS for me
  • demo route never fully loads, or unloads and takes a while to load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Locked
Development

Successfully merging a pull request may close this issue.

2 participants