Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kia: add missing Optima EUR FW versions #33027

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Kia: add missing Optima EUR FW versions #33027

merged 2 commits into from
Jul 25, 2024

Conversation

eivegau
Copy link
Contributor

@eivegau eivegau commented Jul 19, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited
Loading

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@sshane
Copy link
Contributor

sshane commented Jul 19, 2024

What is your dongle ID? For what model year?

@eivegau
Copy link
Contributor Author

eivegau commented Jul 20, 2024 via email

@sshane
Copy link
Contributor

sshane commented Jul 25, 2024

Dongle, platform, VIN Name from VIN 🆚 CarDocs Segments Bad seg tags Good seg tags
aeba7953fb011c0e
KIA_OPTIMA_G4
KNAGW815G........		 KIA 1987 🆚
Kia Optima 2017		 22 routes,
119 segments
(2.0 hours)		 - valid torque params: 114
- all lat active: 4
- no input all lat active: 2

@sshane sshane changed the title Update fingerprints.py Kia: add missing Optima EUR FW versions Jul 25, 2024
@sshane sshane merged commit cd8a603 into commaai:master Jul 25, 2024
15 of 16 checks passed
@sshane sshane mentioned this pull request Jul 25, 2024
Closed
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
@eivegau @sshane
Kia: add missing Optima EUR FW versions (commaai#33027)
805f2ff 
* Update fingerprints.py

* Apply suggestions from code review

---------

Co-authored-by: Shane Smiskol <[email protected]>
old-commit-hash: cd8a603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshane sshane sshane left review comments

Assignees
No one assigned
Labels
car vehicle-specific fingerprint hyundai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eivegau @sshane