Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove redundant save cache step #33052

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented Jul 23, 2024

actions/cache@4 already does the final cache saving step automatically

Copy link
Contributor

github-actions bot commented Jul 23, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@andiradulescu
Copy link
Contributor

the intention might’ve been to save even when it fails?

@maxime-desroches
Copy link
Contributor

@andiradulescu No, the intention was that I didn't know that actions/cache@4 already saved the cache automatically

@maxime-desroches maxime-desroches merged commit 3446941 into commaai:master Jul 24, 2024
19 checks passed
@bongbui321 bongbui321 deleted the cleanup_save_cache branch July 25, 2024 17:23
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants