test explicit scalar attribute type

commercetools · May 30, 2024 · 4b1190c · 4b1190c
1 parent 497d520
commit 4b1190c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/commercetools.Sdk/Tests/commercetools.Api.Serialization.Tests/AttributesTests.cs b/commercetools.Sdk/Tests/commercetools.Api.Serialization.Tests/AttributesTests.cs
@@ -28,7 +28,8 @@ public void MixedSetDeserialization()
             var services = new ServiceCollection();
             services.UseCommercetoolsApiSerialization(new SerializationConfiguration() { AttributeTypeMap = new Dictionary<string, Type>()
             {
-                { "set-mixed", typeof(SetAttribute<decimal>) }
+                { "set-mixed", typeof(SetAttribute<decimal>) },
+                { "decimal", typeof(DecimalAttribute) },
             }});
             var serviceProvider = services.BuildServiceProvider();
             var serializerService = serviceProvider.GetService<IApiSerializerService>();
@@ -37,6 +38,7 @@ public void MixedSetDeserialization()
             Assert.NotNull(deserialized);
             var attributes = deserialized.Attributes;
             Assert.IsType<List<decimal>>(attributes.Get("set-mixed").Value);
+            Assert.IsType<decimal>(attributes.Get("decimal").Value);
 
         }
 

diff --git a/...k/Tests/commercetools.Api.Serialization.Tests/Resources/Attributes/MixedSetAttribute.json b/...k/Tests/commercetools.Api.Serialization.Tests/Resources/Attributes/MixedSetAttribute.json
@@ -5,6 +5,10 @@
     {
       "name": "set-mixed",
       "value": [10, 10.3]
+    },
+    {
+      "name": "decimal",
+      "value": 10.3
     }
   ]
 }
diff --git a/...ls.Sdk/commercetools.Sdk.Api/Serialization/MapperTypeRetrievers/AttributeTypeRetriever.cs b/...ls.Sdk/commercetools.Sdk.Api/Serialization/MapperTypeRetrievers/AttributeTypeRetriever.cs
@@ -138,6 +138,7 @@ private Type GetElementTypeForToken(JsonElement element)
             return tokenType;
         }
 
+        [Obsolete("use GetAttribute(attributeName, element) instead")]
         public IAttribute GetAttribute(JsonElement element)
         {
             var type = GetTypeForToken(element);