Restructure TS Client V3 #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1cef5f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #814 +/- ##
=======================================
Coverage 93.07% 93.07%
=======================================
Files 25 25
Lines 289 289
Branches 14 14
=======================================
Hits 269 269
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lojzatran
reviewed
Oct 1, 2024
packages/sdk-client-v3/src/middleware/auth-middleware/anonymous-session-flow.ts
Show resolved
Hide resolved
packages/sdk-client-v3/src/middleware/auth-middleware/auth-request-builder.ts
Show resolved
Hide resolved
packages/sdk-client-v3/src/middleware/auth-middleware/anonymous-session-flow.ts
Outdated
Show resolved
Hide resolved
packages/sdk-client-v3/src/middleware/auth-middleware/refresh-token-flow.ts
Outdated
Show resolved
Hide resolved
packages/sdk-client-v3/src/middleware/create-concurrent-modification-middleware.ts
Show resolved
Hide resolved
packages/sdk-client-v3/src/middleware/create-http-middleware.ts
Outdated
Show resolved
Hide resolved
ajimae
force-pushed
the
chore/rewrite-async-and-concurrent-execution-strategy
branch
from
a06d053 to
91598d5
Compare
I have updated the PR description to include this. |
lojzatran
approved these changes
Oct 8, 2024
|
Good job! 🚀 |
…and concurrent executions - remove the use of request queue during token fetch - remove promise chain from dispatch function - return response to resolver only when async and concurrent executions are done - remove Buffer module from core SDK packages and replace with browser friendly alternatives - remove async-mutex packages used for concurrent request locking use pure Promise solution - add a response cache to prevent unnecessary calls to coco API - modify type definitions in accordance with the new changes
- rewrite tests to correspond with new changes
- rewrite concurrent middleware integration test
- add release changeset
- rollback some changes in the client.ts file - fix the bug in queue middleware - modify tests to fit the new implementation - add new tests to cover new codes blocks - minor refactor
- remove crypto module reference from SDK - fix type errors and return type values
- add changes to remote
- resolve conflicts on yarn.loc
ajimae
force-pushed
the
chore/rewrite-async-and-concurrent-execution-strategy
branch
from
6b663c4 to
1cef5f0
Compare
ajimae
deleted the
chore/rewrite-async-and-concurrent-execution-strategy
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restructure and rewrite part of the v3 SDK to fix some serious issues encountered by the customers when using the SDK.
Completed Tasks
Associated customer issues