Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#300 - Type Sync Feature. #333

Merged
merged 181 commits into from
Dec 7, 2018
Merged

#300 - Type Sync Feature. #333

merged 181 commits into from
Dec 7, 2018

Conversation

ahmetoz
Copy link
Contributor

@ahmetoz ahmetoz commented Nov 13, 2018 •
edited
Loading

Summary

Adds implementations for the type sync.

Description

Relevant Issues

#300

Note: This PR is equivalent of that PR. You can check old PR here

Note 2: Some related issues that already WIP (some of them are not directly related to type but it can help to know) and should be on different PR.
#197, #313, #330, #331, #329, #325

Todo

  • Tests

    • Unit
    • Integration
    • Benchmark

  • Documentation

  • Add Release Notes entry.

@ahmetoz
#300: Adds implementations for the type sync.
0dcb394 
- Adds the core type sync implementations
- Adds some unit tests
@ahmetoz
#300: fix checkStyles
aedf087
@ahmetoz
#300: add integration test for type sync utilities.
878c733
@ahmetoz
#300: add unit and integration tests for the type sync feature.
7b129fd
@ahmetoz
#300: suppress warning coming from findBugs
f6e2bc7
@ahmetoz
#300: documentation and benchmark for type sync.
c2bb617
@ahmetoz
#300: add constant to type sync benchmark util
5d1fc58
@ahmetoz
#300: fix checkstyleBenchmark
62923b5
@ahmetoz
Merge branch 'master' into 300-feature-type-sync
73cb3af
@ahmetoz
#300: updates releases notes.
973cb09
@ahmetoz
#300: PR review changes, mostly documentation and indentions.
f4fc415
@ahmetoz
#300: PR changes
2ddf05b
@ahmetoz
#300 - update type sync docs.
6f14845
@ahmetoz
#300 - update type sync java docs and change some indention.
9801dbd
@ahmetoz
#300 - update type sync java doc.
de42db0
@ahmetoz
#300 - typo
5a357ce
@ahmetoz
#300 - add comment for updating field definition's type
18970e9
@ahmetoz
Merge branches '300-feature-type-sync' and 'master' of https://github…
338b833 
….com/commercetools/commercetools-sync-java into 300-feature-type-sync

# Conflicts:
#	docs/RELEASE_NOTES.md
@ahmetoz
#300 - change order
079b1df
@ahmetoz
#300 - refactor with using filterEmptyOptionals util
f7a4c76
@ahmetoz
#300 - refactor, do not block error callback
850246d
@ahmetoz
#300 - refactor, comment
4807bf5
@ahmetoz
#300 - checkStyle fix
c6b88d1
@ahmetoz
#300 - adds tests for TypeServiceImpl
2dc8da9
@ahmetoz
#300 - refactor tests.
1d882cb
@ahmetoz
#300 - fix some typos and grammar in type document.
8f45ac2
@ahmetoz
#300 - Review changes.
4f5a08e
@ahmetoz
#300 - Review changes for benchmark.
19a5800
@ahmetoz
#301 - update release notes for type sync
026071b
@ahmetoz
#301 - fix import.
f448662
heshamMassoud and others added 26 commits December 6, 2018 12:17
@heshamMassoud
#300: Add note about FieldType and AttributeType changes.
85dab40
@heshamMassoud
#300: Add a test case for a new draft with different order.
bd01fdb
@heshamMassoud
#300: Remove unneeded asserts.
2128a66
@heshamMassoud
#300: Add a unit test with a definition with a null name.
658a005
@heshamMassoud
#300: Fix unit test names.
d3f8dd8
@heshamMassoud
#300: Add unit test for fieldDefinition with null FieldType.
db1835e
@heshamMassoud
#300: Unexpose enum differs.
dcb95f4
@heshamMassoud
#300: Fix Javadocs.
b5bfa67
@heshamMassoud
#300: Add more readable line spacing.
bbaab01
@heshamMassoud
#300: Move tests to accessible package.
a87995d
@heshamMassoud
#300: Unexpose generic enum differ.
5bbf06d
@heshamMassoud
#300: Remove redundant empty check.
2459b38
@heshamMassoud
#300: Replace singleton lists with optionals.
f6e34d2
@heshamMassoud
#300: Change test names.
4ab3f1d
@heshamMassoud
#300: Fix unit tests.
f84764f
@heshamMassoud
#300: Use query builder.
a4ecf2d
@heshamMassoud
#300: Fix Javadocs.
0c1e47f
@heshamMassoud
#300: Change fixtures class name, package and contents.
24dca2c
@heshamMassoud
#300: Avoid star import for FieldDefinitionFixtures.
7f6912c
@heshamMassoud
#300: Add unit tests for mixed cases.
9c96839
@heshamMassoud
#300: Move fixtures into fixtures class.
b7d4e54
@heshamMassoud
#300: Remove unneeded field definitions from test.
767825f
@heshamMassoud
#300: Reword notes.
98abc39
@ahmetoz
#300 fix checksStyles
7d20528
@heshamMassoud
#300: Fix Checkstyle issues.
edf0981
@heshamMassoud
Merge pull request #349 from commercetools/300-type-sync-review
5377ce7 
300 type sync review
@heshamMassoud
Copy link
Contributor

heshamMassoud commented Dec 6, 2018 •
edited
Loading

Great work @ahmetoz! 🎉

@heshamMassoud heshamMassoud merged commit c00138a into master Dec 7, 2018
@heshamMassoud heshamMassoud deleted the 300-refactor-type-and-product-type-together branch December 7, 2018 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heshamMassoud heshamMassoud heshamMassoud approved these changes

@lojzatran lojzatran lojzatran approved these changes

@butenkor butenkor Awaiting requested review from butenkor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmetoz @codecov-io @heshamMassoud @lojzatran