Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(processor): make sure typebox has the 0.33.x semvar so that it remains compatible with fastify typebox plugin #266

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

joey-koster-ct
Copy link
Contributor

@joey-koster-ct joey-koster-ct commented Nov 21, 2024

The #261 is failing cause of the following issue. Is the same for all connectors. I will update those if we approve of this PR.

In dependabot the @sinclair/typebox is trying to get bumped to 0.34.3 however the @fastify/type-provider-typebox package has a peerDependency for @sinclair/typebox specified as >=0.26 <=0.33.

So as long as the fastify typebox plugin does not get updated we won't be able to install a new version of @sinclair/typebox. This PR updates the package.json so that we will only allow 0.33.x versions thus satisfying the peerDependency. The dependabot PR should work again after rebasing once this merged.

This is the error message from npm:

npm ERR! While resolving: @fastify/[email protected]
npm ERR! Found: @sinclair/[email protected]
npm ERR! node_modules/@sinclair/typebox
npm ERR!   @sinclair/typebox@"0.34.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @sinclair/typebox@">=0.26 <=0.33" from @fastify/[email protected]
npm ERR! node_modules/@fastify/type-provider-typebox
npm ERR!   @fastify/type-provider-typebox@"5.0.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @sinclair/[email protected]
npm ERR! node_modules/@sinclair/typebox
npm ERR!   peer @sinclair/typebox@">=0.26 <=0.33" from @fastify/[email protected]
npm ERR!   node_modules/@fastify/type-provider-typebox
npm ERR!     @fastify/type-provider-typebox@"5.0.1" from the root project

This change will at the long term introduce a tiny bit of maintenance since we will never go above 0.33.x. So if fastity typebox plugin gets updated to support newer versions of typebox we would need to manually update the semver range as done in this pr. But this approach is better then to force it using a resolution.

@joey-koster-ct joey-koster-ct self-assigned this Nov 21, 2024
@joey-koster-ct joey-koster-ct marked this pull request as ready for review November 21, 2024 09:38
@joey-koster-ct joey-koster-ct requested review from a team as code owners November 21, 2024 09:38
@joey-koster-ct joey-koster-ct merged commit 308dac0 into main Nov 25, 2024
2 checks passed
@joey-koster-ct joey-koster-ct deleted the joey-koster-ct/SCC-NONE-downgrade-typebox branch November 25, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants