Skip to content

Commit

Permalink
Use a native link for top bar logo (#2632)
Browse files Browse the repository at this point in the history
* refactor(application-shell): use a native link for top bar logo

* ci: try to fix deployment status error

* chore: added changeset
  • Loading branch information
CarlosCortizasCT authored Jun 3, 2022
1 parent 7e34301 commit 8829ae8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/flat-hounds-switch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@commercetools-frontend/application-shell': patch
---

Update the link for the main logo in the topbar (top left corner) to be a native one
5 changes: 2 additions & 3 deletions packages/application-shell/src/components/app-bar/app-bar.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { TFetchLoggedInUserQuery } from '../../types/generated/mc';

import { Link } from 'react-router-dom';
import { css } from '@emotion/react';
import Spacings from '@commercetools-uikit/spacings';
import { customProperties } from '@commercetools-uikit/design-system';
Expand Down Expand Up @@ -51,9 +50,9 @@ const AppBar = (props: Props) => {
{!props.user ? (
<img src={LogoSVG} width="100%" alt="Logo" />
) : (
<Link to={`/${previousProjectKey || ''}`}>
<a href={`/${previousProjectKey || ''}`}>
<img src={LogoSVG} width="100%" alt="Logo" />
</Link>
</a>
)}
</div>

Expand Down

1 comment on commit 8829ae8

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-923zj2ec0-commercetools.vercel.app

Built with commit 8829ae8.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.