Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Logo link a normal page redirect #1832

Closed
emmenko opened this issue Oct 27, 2020 · 1 comment · Fixed by #2632
Closed

Make the Logo link a normal page redirect #1832

emmenko opened this issue Oct 27, 2020 · 1 comment · Fixed by #2632
Assignees
Labels
👶 good first contribution Good for newcomers 🌗 good rotation topic Good to rotate a member into Application Kit to work on this topic

Comments

@emmenko
Copy link
Member

emmenko commented Oct 27, 2020

Describe the issue

The Logo link currently does a client-side redirect, which eventually ends up in a full page redirect anyway.

<Link to={`/${previousProjectKey || ''}`}>
<img src={LogoSVG} width="100%" alt="Logo" />
</Link>

To avoid possible unnecessary re-renders of the application, we can make it a normal page redirect in the first place.

@emmenko emmenko added 🌗 good rotation topic Good to rotate a member into Application Kit to work on this topic 👶 good first contribution Good for newcomers labels Oct 27, 2020
@mmaltsev-ct
Copy link
Contributor

Let's include this task in the Main navigation refinement effort (#1884).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👶 good first contribution Good for newcomers 🌗 good rotation topic Good to rotate a member into Application Kit to work on this topic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants