Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a native link for top bar logo #2632

Merged
merged 4 commits into from
Jun 3, 2022
Merged

Conversation

CarlosCortizasCT
Copy link
Contributor

Summary

Update the link for the logo in the topbar (top left corner) to be a native one

Description

The link currently does a client-side redirect, which eventually ends up in a full page redirect anyway.
Also, it will help with some errors we've seen in Sentry.

closes #1832

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2022

🦋 Changeset detected

Latest commit: e0e31da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@commercetools-frontend/application-shell Patch
@commercetools-frontend/cypress Patch
merchant-center-application-template-starter Patch
playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to Preview June 1, 2022 11:42 Destroyed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-2h2o40ky8-commercetools.vercel.app
https://appkit-sha-c9be9343f8ca29117a9d1df009f302140ebf6f0a.commercetools.vercel.app
https://appkit-pr-2632.commercetools.vercel.app

Built with commit e0e31da.
This pull request is being automatically deployed with vercel-action

@github-actions github-actions bot temporarily deployed to Preview June 1, 2022 11:55 Destroyed
@github-actions github-actions bot temporarily deployed to Preview June 1, 2022 13:11 Destroyed
@CarlosCortizasCT CarlosCortizasCT requested a review from a team June 2, 2022 07:38
@github-actions github-actions bot temporarily deployed to Preview June 3, 2022 08:37 Destroyed
@github-actions github-actions bot temporarily deployed to Preview June 3, 2022 10:01 Destroyed
@CarlosCortizasCT CarlosCortizasCT merged commit 8829ae8 into main Jun 3, 2022
@CarlosCortizasCT CarlosCortizasCT deleted the cm-update-logo-link branch June 3, 2022 10:16
@ghost ghost mentioned this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Logo link a normal page redirect
4 participants