refactor(config): load the config as a JS module instead of parsing it as JSON #2599
Conversation
🦋 Changeset detectedLatest commit: 73b28db The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const result = get(moduleExport, 'default', moduleExport); | ||
|
|
||
| // Write the application config to `stdout`so that the main program can read it. | ||
| process.stdout.write(JSON.stringify(result)); |
There was a problem hiding this comment.
Before this was executed as a Node script. The config was then printed to stdout and parsed from the child process.
| }); | ||
|
|
||
| // Require the module. It's expected that the module exports the application config | ||
| const moduleExport = require(filePath); |
There was a problem hiding this comment.
Now we simply require the JS module, no JSON serialization.
This allows to define and preserve JS functions into the application config (useful for example for dev server plugins)
emmenko
force-pushed
the
nm-config-load-as-module
branch
from
8fff87e to
59929db
Compare
emmenko
force-pushed
the
nm-config-load-as-module
branch
from
4b7d889 to
73b28db
Compare
|
So this is not going anywhere, as I don't like any of the approaches I tried. The main driver for this was to be able to define functions within the config and be able to use them. For example, for Vite to pass extra plugins and use them when starting the dev server. I'm opting now for a different approach, to have plugins defined in a separate file and simply reference the file path in the custom app config. Small downside is that there would be another file but I think it's a reasonable tradeoff. |
|
Closing as there would be a different approach. |
Basic work for continuing with #2577