Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(application-config): shared tsconfig.json #2628

Merged
merged 5 commits into from
Jun 3, 2022
Merged

feat(application-config): shared tsconfig.json #2628

merged 5 commits into from
Jun 3, 2022

Conversation

kark
Copy link
Contributor

@kark kark commented May 27, 2022 •
edited by emmenko
Loading

Ref #1668

Summary

Exposes a base tsconfig.json file to extend in Custom Applications.

@changeset-bot
Copy link

changeset-bot bot commented May 27, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: cb2b2ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@commercetools-frontend/application-config Minor
@commercetools-frontend/application-shell Minor
@commercetools-frontend/cypress Minor
@commercetools-frontend/mc-html-template Minor
@commercetools-frontend/mc-scripts Minor
merchant-center-application-template-starter Patch
playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to Preview May 27, 2022 17:41 Destroyed
@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2022 •
edited
Loading

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-ludhk8e12-commercetools.vercel.app
https://appkit-sha-daed9f28c913fb129294655050daee2f4568f679.commercetools.vercel.app
https://appkit-pr-2628.commercetools.vercel.app

Built with commit cb2b2ea.
This pull request is being automatically deployed with vercel-action

emmenko
emmenko reviewed May 27, 2022
View reviewed changes
packages/tsconfig/README.md Outdated

```json
{
"extends": "@commercetools-frontend/tsconfig"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be

Suggested change
"extends": "@commercetools-frontend/tsconfig"
"extends": "@commercetools-frontend/tsconfig/tsconfig.json"

However, seeing this makes me wonder if we really need an extra package for it...maybe we can include the tsconfig.json file in one of the required packages like application-config or application-shell... 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we update this example here, I believe we should also update it in the changeset.

Regarding the question raised about whether creating or not a new package, personally I think the application-config package would be a good fit to export this configuration file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 6dbbc90

@kark kark changed the title feat(tsconfig): shared tsconfig.json as a package feat(tsconfig):tsconfig.json shared as a package May 27, 2022
@github-actions github-actions bot temporarily deployed to Preview May 30, 2022 07:54 Destroyed
@kark kark changed the title feat(tsconfig):tsconfig.json shared as a package feat(application-config): sharedtsconfig.json May 30, 2022
@kark kark changed the title feat(application-config): sharedtsconfig.json feat(application-config): shared tsconfig.json May 30, 2022
@github-actions github-actions bot temporarily deployed to Preview May 30, 2022 08:36 Destroyed
@kark kark requested review from emmenko and CarlosCortizasCT June 2, 2022 07:56
CarlosCortizasCT
CarlosCortizasCT approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot temporarily deployed to Preview June 2, 2022 08:01 Destroyed
@github-actions github-actions bot temporarily deployed to Preview June 2, 2022 08:02 Destroyed
emmenko
emmenko approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a file tsconfig/tsconfig.json seemed a bit unnecessary to me, so I renamed it to tsconfig-mc-app.json.

I also cleaned up a bit the default options and removed the types option, as this is usually project/repo specific and should be provided on demand.

@github-actions github-actions bot temporarily deployed to Preview June 3, 2022 09:49 Destroyed
@github-actions github-actions bot temporarily deployed to Preview June 3, 2022 09:50 Destroyed
@emmenko emmenko mentioned this pull request Jun 3, 2022
Open
10 tasks
@github-actions github-actions bot temporarily deployed to Preview June 3, 2022 10:17 Destroyed
@kark kark merged commit 0b3ea75 into main Jun 3, 2022
@kark kark deleted the kk-tsconfig branch June 3, 2022 10:34
@ghost ghost mentioned this pull request Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosCortizasCT CarlosCortizasCT CarlosCortizasCT approved these changes

@emmenko emmenko emmenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kark @emmenko @CarlosCortizasCT