Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mc-scripts): manually group some vendor chunks #2998

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Mar 10, 2023

Branched off #2995

Extracted from #2821

To reduce the main bundle chunk even more, we can instruct the bundlers to group certain vendor packages in specific groups. As a result, the main bundle will have a smaller size. Users (via browsers) will then only need to download the smaller main bundle when it gets updated (caching) as the other vendor chunks didn't change (unless via dependency updates).

I found this article that explains well how and why it's useful like that: https://www.codemzy.com/blog/react-bundle-size-webpack-code-splitting

Screenshot 2023-03-10 at 22 18 09

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

🦋 Changeset detected

Latest commit: 59522c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@commercetools-frontend/mc-scripts Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-local/playground Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/cypress Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/custom-applications Patch
@commercetools-website/components-playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-fthtw1ixu-commercetools.vercel.app
https://appkit-sha-877ffb39b5e6f83ec35f32e243368224ceddefac.commercetools.vercel.app
https://appkit-pr-2998.commercetools.vercel.app

Built with commit 59522c8.
This pull request is being automatically deployed with vercel-action

@emmenko emmenko force-pushed the nm-props-cleanup branch 2 times, most recently from 9325e29 to 461f7ac Compare March 13, 2023 11:43
@emmenko emmenko force-pushed the nm-bundle-manual-chunks branch from a4d36e5 to b9caf83 Compare March 13, 2023 11:45
Base automatically changed from nm-props-cleanup to main March 15, 2023 10:30
@emmenko emmenko force-pushed the nm-bundle-manual-chunks branch from b9caf83 to dc67bff Compare March 15, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant