Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomViewShell component not using provided custom Apollo client #3427

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

CarlosCortizasCT
Copy link
Contributor

Summary

CustomViewShell component not using provided custom Apollo client

Description

The apolloClient property in the CustomViewShell component was not being used internally, making it impossible for consumers to user a custom Apollo client.

@CarlosCortizasCT CarlosCortizasCT requested a review from a team as a code owner March 5, 2024 17:21
Copy link

changeset-bot bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: 17005f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@commercetools-frontend/application-shell Patch
@commercetools-frontend/cypress Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Patch
@commercetools-applications/merchant-center-custom-view-template-starter Patch
@commercetools-local/playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-website/components-playground Patch
@commercetools-website/custom-views Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 5:21pm

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Deploy preview for application-kit-custom-views ready!

✅ Preview
https://application-kit-custom-views-jjuxae6hl-commercetools.vercel.app
https://appkit-cv-sha-b65a92dd2885f36033771739c80cd892d655b1f2.commercetools.vercel.app
https://appkit-cv-pr-3427.commercetools.vercel.app

Built with commit 17005f7.
This pull request is being automatically deployed with vercel-action

@CarlosCortizasCT CarlosCortizasCT merged commit 02cd76b into main Mar 6, 2024
20 checks passed
@CarlosCortizasCT CarlosCortizasCT deleted the cm-fix-custom-view-apollo-client branch March 6, 2024 09:36
@ct-changesets ct-changesets bot mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants