fix(cypress): onBeforeLoad being called during login #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8548e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tdeekens
commented
Apr 4, 2024
| @@ -125,7 +125,7 @@ function loginByForm(commandOptions: CommandLoginOptions) { | |||
| // const mcFrontendHostname = mcUrl.hostname.replace('mc-api', 'mc'); | |||
|
|
|||
| function authCallback() { | |||
| cy.visit(url); | |||
| cy.visit(url, { onBeforeLoad: commandOptions.onBeforeLoad }); | |||
There was a problem hiding this comment.
Verified this locally with a patched package.
kark
approved these changes
Apr 5, 2024
Merged
ddouglasz
pushed a commit
that referenced
this pull request
May 22, 2024
* fix(cypress): onBeforeLoad being called during login * Create large-bats-travel.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
onBeforeLoadnever seems to be called which this intends to fix.Description
In the
loginByOidcwe call theonBeforeLoadlike:I noticed that we do not do this when logging in via the form. This causes issues internally when we use the general
loginToMerchantCentercommand which we often pass anonBeforeLoadto e.g. set local storage values to hide collapse the menu or hide certain models (like for rebranding).We could either invoke the
onBeforeLoadin theauthCallbackor when navigating to theinitialRoute. The latter seems unexpected as you then only invoke the callback when another parameter is passed.