Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Drop support for Node.js v16 #3530

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[Breaking] Drop support for Node.js v16 #3530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
27e8ff1
chore: drop support for node.js v16
emmenko May 16, 2024
452f69f
chore(stylelint): ignore output folder
emmenko May 16, 2024
cf72df9
refactor: migrate to vite v5, use tsconfig/node22
emmenko May 16, 2024
6d669c6
chore: refine node versions
emmenko Dec 5, 2024
2115153
refactor: update vite to v6
emmenko Dec 5, 2024
2e264d5
fix: patch vite bundle analyzer
emmenko Dec 5, 2024
af0ab10
refactor(playground): remove file extension
emmenko Dec 5, 2024
93be38b
refactor(playground): rename constants.js to constants.mjs
emmenko Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/five-cougars-marry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
'@commercetools-frontend/application-shell-connectors': major
'@commercetools-backend/eslint-config-node': major
'@commercetools-frontend/mc-dev-authentication': major
'@commercetools-frontend/eslint-config-mc-app': major
'@commercetools-frontend/babel-preset-mc-app': major
'@commercetools-frontend/application-config': major
'@commercetools-frontend/application-shell': major
'@commercetools-frontend/mc-html-template': major
'@commercetools-frontend/create-mc-app': major
'@commercetools-frontend/mc-scripts': major
'@commercetools-frontend/codemod': major
'@commercetools-local/playground': major
---

Drop support for Node.js `v16`, which reached EOL. The minimal required version is `v18` but we recommend to use `v20` or `v22` if possible.
21 changes: 21 additions & 0 deletions .changeset/modern-suits-decide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
'@commercetools-frontend/application-shell-connectors': major
'@commercetools-backend/eslint-config-node': major
'@commercetools-frontend/mc-dev-authentication': major
'@commercetools-frontend/eslint-config-mc-app': major
'@commercetools-website/components-playground': major
'@commercetools-frontend/babel-preset-mc-app': major
'@commercetools-frontend/application-config': major
'@commercetools-frontend/application-shell': major
'@commercetools-frontend/mc-html-template': major
'@commercetools-backend/express': major
'@commercetools-backend/loggers': major
'@commercetools-frontend/create-mc-app': major
'@commercetools-frontend/mc-scripts': major
'@commercetools-local/visual-testing-app': major
'@commercetools-frontend/codemod': major
'@commercetools-frontend/cypress': major
'@commercetools-local/playground': major
---

Migrate to Vite `v6`. If you have Vite enabled via `ENABLE_EXPERIMENTAL_VITE_BUNDLER` and you are using `vite` as a dependency, make sure you upgrade to `v6` (see [Migration from v4](https://v5.vite.dev/guide/migration.html) and [Migration from v5](https://vite.dev/guide/migration.html)).
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
22
2 changes: 1 addition & 1 deletion application-templates/starter-typescript/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
2 changes: 1 addition & 1 deletion application-templates/starter/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
2 changes: 1 addition & 1 deletion custom-views-templates/starter-typescript/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
2 changes: 1 addition & 1 deletion custom-views-templates/starter/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
1 change: 1 addition & 0 deletions jest.stylelint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ module.exports = {
'.cache',
'.vercel',
'.spec.js',
'.vercel',
'.visualspec.js',
'.visualroute.js',
'packages/jest-stylelint-runner/',
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"@tsconfig/cypress": "^1.0.1",
"@types/eslint": "^8.44.2",
"@types/jest": "^29.5.4",
"@types/node": "^18.17.14",
"@types/node": "^22.10.1",
"@types/rosie": "^0.0.45",
"@types/testing-library__jest-dom": "^5.14.9",
"@types/uuid": "^9.0.3",
Expand Down Expand Up @@ -182,11 +182,11 @@
},
"patchedDependencies": {
"[email protected]": "patches/[email protected]",
"vite-bundle-analyzer@0.12.1": "patches/vite-bundle-analyzer@0.12.1.patch"
"vite-bundle-analyzer@0.15.2": "patches/vite-bundle-analyzer@0.15.2.patch"
}
},
"engines": {
"node": "18.x",
"node": ">=22",
"npm": ">=6",
"pnpm": ">=8"
},
Expand Down
4 changes: 2 additions & 2 deletions packages-backend/eslint-config-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
"eslint": "8.x"
},
"devDependencies": {
"@tsconfig/node16": "^16.1.1",
"@tsconfig/node22": "^22.0.0",
"eslint": "8.57.0"
},
"engines": {
"node": "16.x || >=18.0.0"
"node": "18.x || 20.x || >=22.0.0"
}
}
2 changes: 1 addition & 1 deletion packages-backend/eslint-config-node/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": "@tsconfig/node16/tsconfig.json"
"extends": "@tsconfig/node22/tsconfig.json"
}
4 changes: 2 additions & 2 deletions packages-backend/express/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@
"@babel/runtime": "^7.22.15",
"@babel/runtime-corejs3": "^7.22.15",
"@types/express": "^4.17.17",
"@types/node": "^18.17.14",
"@types/node": "^22.10.1",
"express": "4.20.0",
"express-jwt": "8.4.1",
"jwks-rsa": "2.1.5"
},
"devDependencies": {
"@tsconfig/node16": "^16.1.1",
"@tsconfig/node22": "^22.0.0",
"@types/jsonwebtoken": "^9.0.2",
"jose": "2.0.7",
"msw": "0.49.3"
Expand Down
2 changes: 1 addition & 1 deletion packages-backend/express/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": "@tsconfig/node16/tsconfig.json"
"extends": "@tsconfig/node22/tsconfig.json"
}
2 changes: 1 addition & 1 deletion packages-backend/loggers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"winston": "3.13.0"
},
"devDependencies": {
"@tsconfig/node16": "^16.1.1",
"@tsconfig/node22": "^22.0.0",
"@types/express": "^4.17.17",
"express": "4.20.0"
}
Expand Down
2 changes: 1 addition & 1 deletion packages-backend/loggers/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": "@tsconfig/node16/tsconfig.json"
"extends": "@tsconfig/node22/tsconfig.json"
}
2 changes: 1 addition & 1 deletion packages/application-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@
"shelljs": "0.8.5"
},
"engines": {
"node": "16.x || >=18.0.0"
"node": "18.x || 20.x || >=22.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/application-shell-connectors/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@
"react": "17.x"
},
"engines": {
"node": "16.x || >=18.0.0"
"node": "18.x || 20.x || >=22.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/application-shell/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,6 @@
"redux": "4.x"
},
"engines": {
"node": "16.x || >=18.0.0"
"node": "18.x || 20.x || >=22.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/babel-preset-mc-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,6 @@
"core-js": "^3.32.2"
},
"engines": {
"node": "16.x || >=18.0.0"
"node": "18.x || 20.x || >=22.0.0"
}
}
4 changes: 2 additions & 2 deletions packages/codemod/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@
"devDependencies": {
"@commercetools-frontend/application-components": "workspace:*",
"@emotion/react": "^11.11.4",
"@tsconfig/node16": "^16.1.1",
"@tsconfig/node22": "^22.0.0",
"@types/glob": "8.1.0",
"@types/jscodeshift": "0.11.11",
"rimraf": "5.0.7",
"typescript": "5.0.4"
},
"engines": {
"node": "16.x || >=18.0.0"
"node": "18.x || 20.x || >=22.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/codemod/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node16/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"compilerOptions": {
"resolveJsonModule": true,
"outDir": "./build"
Expand Down
4 changes: 2 additions & 2 deletions packages/create-mc-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
"semver": "7.6.2"
},
"devDependencies": {
"@tsconfig/node16": "^16.1.1"
"@tsconfig/node22": "^22.0.0"
},
"engines": {
"node": "16.x || >=18.0.0"
"node": "18.x || 20.x || >=22.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/create-mc-app/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node16/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"compilerOptions": {
"resolveJsonModule": true
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cypress/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"uuid": "9.0.1"
},
"devDependencies": {
"@tsconfig/node16": "^16.1.1",
"@tsconfig/node22": "^22.0.0",
"cypress": "12.17.4"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/cypress/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"extends": "@tsconfig/node16/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"compilerOptions": {
"lib": ["DOM", "DOM.Iterable"]
"lib": ["DOM", "DOM.Iterable", "ESNext"]
},
"include": ["./src"]
}
2 changes: 1 addition & 1 deletion packages/eslint-config-mc-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@
"eslint": "8.57.0"
},
"engines": {
"node": "16.x || >=18.0.0"
"node": "18.x || 20.x || >=22.0.0"
}
}
4 changes: 2 additions & 2 deletions packages/mc-dev-authentication/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
},
"devDependencies": {
"@commercetools-frontend/application-config": "workspace:*",
"@tsconfig/node16": "^16.1.1",
"@tsconfig/node22": "^22.0.0",
"@types/connect": "^3.4.36",
"connect": "^3.7.0"
},
"engines": {
"node": "16.x || >=18.0.0"
"node": "18.x || 20.x || >=22.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/mc-dev-authentication/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": "@tsconfig/node16/tsconfig.json"
"extends": "@tsconfig/node22/tsconfig.json"
}
4 changes: 2 additions & 2 deletions packages/mc-html-template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@
"uglifycss": "0.0.29"
},
"devDependencies": {
"@tsconfig/node16": "^16.1.1",
"@tsconfig/node22": "^22.0.0",
"@types/serialize-javascript": "^5.0.2",
"html-webpack-plugin": "5.6.0",
"webpack": "5.94.0"
},
"engines": {
"node": "16.x || >=18.0.0"
"node": "18.x || 20.x || >=22.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/mc-html-template/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": "@tsconfig/node16/tsconfig.json"
"extends": "@tsconfig/node22/tsconfig.json"
}
12 changes: 6 additions & 6 deletions packages/mc-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@
"@types/prompts": "^2.4.4",
"@types/svgo": "^2.6.4",
"@types/webpack-bundle-analyzer": "^4.6.0",
"@vitejs/plugin-react": "4.3.1",
"@vitejs/plugin-react-swc": "3.7.0",
"@vitejs/plugin-react": "4.3.4",
"@vitejs/plugin-react-swc": "3.7.2",
"autoprefixer": "^10.4.15",
"babel-loader": "8.3.0",
"browserslist": "^4.21.10",
Expand Down Expand Up @@ -108,16 +108,16 @@
"terser-webpack-plugin": "5.3.10",
"thread-loader": "3.0.4",
"url": "^0.11.0",
"vite": "~4.5.3",
"vite-bundle-analyzer": "0.12.1",
"vite": "~6.0.3",
"vite-bundle-analyzer": "0.15.2",
"webpack": "5.94.0",
"webpack-bundle-analyzer": "4.10.2",
"webpack-dev-server": "4.15.2",
"webpackbar": "5.0.2"
},
"devDependencies": {
"@commercetools-test-data/custom-view": "^8.0.0",
"@tsconfig/node16": "^16.1.1",
"@tsconfig/node22": "^22.0.0",
"@types/fs-extra": "^11.0.1",
"@types/lodash": "^4.14.198",
"@types/mock-fs": "^4.13.1",
Expand All @@ -130,6 +130,6 @@
"rimraf": "5.0.7"
},
"engines": {
"node": "16.x || >=18.0.0"
"node": "18.x || 20.x || >=22.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/mc-scripts/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node16/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"compilerOptions": {
"resolveJsonModule": true
}
Expand Down
63 changes: 0 additions & 63 deletions patches/[email protected]
View file
Open in desktop

This file was deleted.

Loading
Loading