feat: add babel-plugin-formatjs to babel-preset-mc-app
#3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 53c3952 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ragafus
force-pushed
the
rg-babel-plugin-formatjs
branch
from
a32f3df to
92e42ea
Compare
ragafus
changed the title
babel-plugin-formatjs to babel-preset-mc-app
…ripts` # Conflicts: # pnpm-lock.yaml
ragafus
force-pushed
the
rg-babel-plugin-formatjs
branch
from
92e42ea to
11e4578
Compare
ragafus
force-pushed
the
rg-babel-plugin-formatjs
branch
from
11e4578 to
53c3952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this PR is to add
babel-plugin-formatjsto thebabel-preset-mc-appandmc-scriptspackages in order to avoid bloating bundles with useless data fromformatjsmessages (description,defaultMessageprops).Description
A couple of flags are added (see https://formatjs.github.io/docs/tooling/babel-plugin/#options):
i18nAst: Pre-parsedefaultMessageinto AST for faster runtime perfi18nRemoveDefaultMessage: RemovedefaultMessagefield in generated js after extraction