Support custom generator #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the found ApplicationSet contains no Git configuration Telefonistka crashes. Guarding against the missing configuration should avoid the crash.
hnnsgstfssn
force-pushed
the
SD-940-stuck-pending
branch
from
6d62590 to
ec1c70c
Compare
Adds support for custom generator as long as the generator has an input parameter named "path". Note that it would probably be advisable to make it configurable, but this is left as a future exercise for the reader.
hnnsgstfssn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the found ApplicationSet contains no Git configuration Telefonistka crashes.
Guarding against the missing configuration should avoid the crash.
Also adds support for custom generator as long as the generator has an input
parameter named "path".
Note that it would probably be advisable to make it configurable, but
this is left as a future exercise for the reader.