Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SD-555 Document ArgoCD features #66

Merged
merged 14 commits into from
Jan 30, 2025
Merged

SD-555 Document ArgoCD features #66

merged 14 commits into from
Jan 30, 2025

Conversation

Oded-B
Copy link
Collaborator

@Oded-B Oded-B commented Jan 27, 2025 •
edited
Loading

Description

Document all ArgoCD features in one place

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

hnnsgstfssn
hnnsgstfssn reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@hnnsgstfssn hnnsgstfssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass with smaller things, but looks good overall to me.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/argocd.md Outdated Show resolved Hide resolved
docs/argocd.md Outdated Show resolved Hide resolved
docs/argocd.md Outdated Show resolved Hide resolved
docs/argocd.md Outdated Show resolved Hide resolved
docs/argocd.md Outdated Show resolved Hide resolved
docs/argocd.md Outdated Show resolved Hide resolved
docs/argocd.md Outdated Show resolved Hide resolved
Oded-B and others added 3 commits January 28, 2025 09:14
@Oded-B @hnnsgstfssn
Apply suggestions from code review
53f3d8c 
Co-authored-by: Hannes Gustafsson <[email protected]>
@Oded-B @hnnsgstfssn
Apply suggestions from code review
e8e1c9a 
Co-authored-by: Hannes Gustafsson <[email protected]>
@Oded-B @hnnsgstfssn
Update docs/argocd.md
9e71eda 
Co-authored-by: Hannes Gustafsson <[email protected]>
@Oded-B Oded-B marked this pull request as ready for review January 28, 2025 08:44
@Oded-B Oded-B requested a review from a team as a code owner January 28, 2025 08:44
@hnnsgstfssn hnnsgstfssn changed the title Document ArgoCD features SD-555 Document ArgoCD features Jan 30, 2025
ashvarts
ashvarts approved these changes Jan 30, 2025
View reviewed changes
docs/argocd.md Outdated Show resolved Hide resolved
Oded-B
Oded-B commented Jan 30, 2025
View reviewed changes
docs/argocd.md Outdated Show resolved Hide resolved
@Oded-B Oded-B merged commit dcd46e1 into main Jan 30, 2025
5 checks passed
@Oded-B Oded-B deleted the argocd-features-doc branch January 30, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashvarts ashvarts ashvarts approved these changes

@hnnsgstfssn hnnsgstfssn Awaiting requested review from hnnsgstfssn hnnsgstfssn is a code owner automatically assigned from commercetools/special-delivery

@Freyert Freyert Awaiting requested review from Freyert Freyert is a code owner automatically assigned from commercetools/special-delivery

@yzdann yzdann Awaiting requested review from yzdann yzdann is a code owner automatically assigned from commercetools/special-delivery

@jared-logan-patrick-ct jared-logan-patrick-ct Awaiting requested review from jared-logan-patrick-ct jared-logan-patrick-ct is a code owner automatically assigned from commercetools/special-delivery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oded-B @hnnsgstfssn @ashvarts