fix(calendar-utils): getPaddingDayCount helper function (#2669)

* fix(calendar-utils): fix getPaddingDayCount helper chore: changeset test: update correct retured value test: update description * refactor: kiss * refactor: remove misleading comment * chore: empty
commercetools · Dec 19, 2023 · 6bec284 · 6bec284 · vercel · Dec 19, 2023
1 parent 33cccc8
commit 6bec284
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/.changeset/two-dragons-boil.md b/.changeset/two-dragons-boil.md
@@ -0,0 +1,5 @@
+---
+'@commercetools-uikit/calendar-utils': patch
+---
+
+Fix `getPaddingDayCount` helper function
diff --git a/packages/calendar-utils/src/calendar.spec.js b/packages/calendar-utils/src/calendar.spec.js
@@ -88,4 +88,8 @@ describe('getPaddingDayCount', () => {
     expect(getPaddingDayCount('2019-01-01')).toEqual(2);
     expect(getPaddingDayCount(NaN)).toEqual(0);
   });
+  it('should return different values for different locale', () => {
+    expect(getPaddingDayCount('2023-10-23', 'en-US')).toEqual(0);
+    expect(getPaddingDayCount('2023-10-23', 'en-GB')).toEqual(6);
+  });
 });
diff --git a/packages/calendar-utils/src/calendar.ts b/packages/calendar-utils/src/calendar.ts
@@ -1,5 +1,4 @@
 import moment from 'moment';
-import inRange from 'lodash/inRange';
 import type { MomentInput, DurationInputArg1 } from 'moment';
 
 export const getDaysInMonth = (day: MomentInput) => moment(day).daysInMonth();
@@ -20,8 +19,7 @@ export const getPaddingDayCount = (day: MomentInput, locale: string) => {
   const firstDayOfMonth = moment(day).startOf('month').day();
   const paddingDayCount = (firstDayOfMonth - firstDayOfWeek + 7) % 7;
 
-  // ensure number is always positive
-  return inRange(paddingDayCount, 0, 6) ? paddingDayCount : 0;
+  return Number.isNaN(paddingDayCount) ? 0 : paddingDayCount;
 };
 
 export const getWeekdayNames = (locale: string) => {