-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate UI kit from react-router v5 to react-router v6 #2999
Open
ddouglasz
wants to merge
14
commits into
main
Choose a base branch
from
preview/FEC-99-migrate-ui-kit-to-react-router-v-6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate UI kit from react-router v5 to react-router v6 #2999
ddouglasz
wants to merge
14
commits into
main
from
preview/FEC-99-migrate-ui-kit-to-react-router-v-6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddouglasz
requested review from
stephsprinkle,
jaikamat,
tylermorrisford,
ByronDWall and
misama-ct
and removed request for
a team
November 28, 2024 13:29
🦋 Changeset detectedLatest commit: 47e9b50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 98 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CarlosCortizasCT
added
the
fe-chapter-rotation
Tasks coming from frontend chapter work
label
Nov 28, 2024
ddouglasz
changed the title
Preview/fec 99 migrate UI kit to react router v 6
Migrate UI kit from react-router v5 to react-router v6
Dec 2, 2024
* refactor: temporary silence warning * fix: adjust vrt * fix: adjust vrt * chore(react router v6): fix vrt * chore(react router v6): update icons vrt to rr6 syntax * chore(react router v6): update icons vrt to rr6 syntax localized text input * chore(react router v6): update icons vrt to rr6 syntax theme provider * chore(react router v6): update icons vrt to rr6 syntax theme provider * chore(react router v6): update icons vrt to rr6 syntax theme provider * chore(react router v6): update icons vrt to rr6 syntax primary dropdown action * chore(react router v6): update icons vrt to rr6 syntax * chore(react router v6): update icons vrt to rr6 syntax * chore(react router v6): update icons vrt to rr6 syntax * chore(react router v6): update icons vrt to rr6 syntax --------- Co-authored-by: Ddouglasz <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate react-router from v5 to v6
Description
These changes introduce a migration from react-router v5 to v6. The most obvious change is how the component is now used. Unlike the the pattern in v5, where the
to
props in a nested route requires you to manually interpolatematch.url
for a relative route, v6 accepts a string where all urls are automatically relative routes.