Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate UI kit from react-router v5 to react-router v6 #2999

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ddouglasz
Copy link
Contributor

Summary

Migrate react-router from v5 to v6

Description

These changes introduce a migration from react-router v5 to v6. The most obvious change is how the component is now used. Unlike the the pattern in v5, where the to props in a nested route requires you to manually interpolate match.url for a relative route, v6 accepts a string where all urls are automatically relative routes.

@ddouglasz ddouglasz requested a review from a team as a code owner November 28, 2024 13:29
@ddouglasz ddouglasz requested review from stephsprinkle, jaikamat, tylermorrisford, ByronDWall and misama-ct and removed request for a team November 28, 2024 13:29
Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: 47e9b50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 98 packages
Name Type
@commercetools-uikit/async-creatable-select-field Major
@commercetools-uikit/localized-rich-text-input Major
@commercetools-uikit/async-select-field Major
@commercetools-uikit/secondary-button Major
@commercetools-uikit/primary-action-dropdown Major
@commercetools-uikit/link-button Major
@commercetools-uikit/select-input Major
@commercetools-uikit/icons Major
@commercetools-uikit/card Major
@commercetools-uikit/link Major
@commercetools-uikit/tag Major
visual-testing-app Major
@commercetools-uikit/buttons Major
@commercetools-uikit/fields Major
@commercetools-uikit/inputs Major
@commercetools-frontend/ui-kit Major
@commercetools-uikit/data-table-manager Major
@commercetools-uikit/dropdown-menu Major
@commercetools-uikit/filters Major
@commercetools-uikit/pagination Major
@commercetools-uikit/select-field Major
@commercetools-uikit/calendar-utils Major
@commercetools-uikit/collapsible-panel Major
@commercetools-uikit/data-table Major
@commercetools-uikit/field-label Major
@commercetools-uikit/notifications Major
@commercetools-uikit/password-field Major
@commercetools-uikit/async-creatable-select-input Major
@commercetools-uikit/async-select-input Major
@commercetools-uikit/checkbox-input Major
@commercetools-uikit/creatable-select-input Major
@commercetools-uikit/date-input Major
@commercetools-uikit/date-range-input Major
@commercetools-uikit/date-time-input Major
@commercetools-uikit/input-utils Major
@commercetools-uikit/localized-money-input Major
@commercetools-uikit/localized-multiline-text-input Major
@commercetools-uikit/localized-text-input Major
@commercetools-uikit/money-input Major
@commercetools-uikit/multiline-text-input Major
@commercetools-uikit/radio-input Major
@commercetools-uikit/rich-text-input Major
@commercetools-uikit/rich-text-utils Major
@commercetools-uikit/search-text-input Major
@commercetools-uikit/select-utils Major
@commercetools-uikit/selectable-search-input Major
@commercetools-uikit/time-input Major
@commercetools-uikit/quick-filters Major
@commercetools-uikit/creatable-select-field Major
@commercetools-uikit/date-field Major
@commercetools-uikit/date-range-field Major
@commercetools-uikit/date-time-field Major
@commercetools-uikit/localized-multiline-text-field Major
@commercetools-uikit/localized-text-field Major
@commercetools-uikit/money-field Major
@commercetools-uikit/multiline-text-field Major
@commercetools-uikit/number-field Major
@commercetools-uikit/radio-field Major
@commercetools-uikit/search-select-field Major
@commercetools-uikit/text-field Major
@commercetools-uikit/time-field Major
@commercetools-uikit/search-select-input Major
@commercetools-uikit/number-input Major
@commercetools-uikit/password-input Major
@commercetools-uikit/text-input Major
@commercetools-uikit/toggle-input Major
@commercetools-uikit/design-system Major
@commercetools-uikit/calendar-time-utils Major
@commercetools-uikit/hooks Major
@commercetools-uikit/i18n Major
@commercetools-uikit/localized-utils Major
@commercetools-uikit/utils Major
@commercetools-uikit/accessible-hidden Major
@commercetools-uikit/avatar Major
@commercetools-uikit/collapsible-motion Major
@commercetools-uikit/collapsible Major
@commercetools-uikit/constraints Major
@commercetools-uikit/field-errors Major
@commercetools-uikit/field-warnings Major
@commercetools-uikit/grid Major
@commercetools-uikit/label Major
@commercetools-uikit/loading-spinner Major
@commercetools-uikit/messages Major
@commercetools-uikit/progress-bar Major
@commercetools-uikit/stamp Major
@commercetools-uikit/text Major
@commercetools-uikit/tooltip Major
@commercetools-uikit/view-switcher Major
@commercetools-uikit/accessible-button Major
@commercetools-uikit/flat-button Major
@commercetools-uikit/icon-button Major
@commercetools-uikit/primary-button Major
@commercetools-uikit/secondary-icon-button Major
@commercetools-uikit/spacings-inline Major
@commercetools-uikit/spacings-inset-squish Major
@commercetools-uikit/spacings-inset Major
@commercetools-uikit/spacings-stack Major
@commercetools-uikit/spacings Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 2:35pm

@CarlosCortizasCT CarlosCortizasCT added the fe-chapter-rotation Tasks coming from frontend chapter work label Nov 28, 2024
@ddouglasz ddouglasz changed the title Preview/fec 99 migrate UI kit to react router v 6 Migrate UI kit from react-router v5 to react-router v6 Dec 2, 2024
CarlosCortizasCT and others added 2 commits December 3, 2024 15:29
* refactor: temporary silence warning

* fix: adjust vrt

* fix: adjust vrt

* chore(react router v6): fix vrt

* chore(react router v6): update icons vrt to rr6 syntax

* chore(react router v6): update icons vrt to rr6 syntax localized text input

* chore(react router v6): update icons vrt to rr6 syntax theme provider

* chore(react router v6): update icons vrt to rr6 syntax theme provider

* chore(react router v6): update icons vrt to rr6 syntax theme provider

* chore(react router v6): update icons vrt to rr6 syntax primary dropdown action

* chore(react router v6): update icons vrt to rr6 syntax

* chore(react router v6): update icons vrt to rr6 syntax

* chore(react router v6): update icons vrt to rr6 syntax

* chore(react router v6): update icons vrt to rr6 syntax

---------

Co-authored-by: Ddouglasz <[email protected]>
@ddouglasz
Copy link
Contributor Author

⚠️ This PR is on hold for now. Until after the react-18 migration work is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-chapter-rotation Tasks coming from frontend chapter work 🛑 Status: blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants