Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCT-1311 - reduce icon bundle size 2 #3011

Closed
wants to merge 2 commits into from
Closed

FCT-1311 - reduce icon bundle size 2 #3011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c444e8
feat(icons): [publish_preview] update icon template with new imports,…
ByronDWall Dec 10, 2024
4851395
feat(icons): [publish_preview] work?
ByronDWall Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ If you want to modify an existing translation, you will need to manually edit th
To add new icons in the `@commercetools-uikit/icons` package:

1. Add the raw SVG file to the `packages/components/icons/src/svg` folder. Make sure the file name ends with `.react.svg`.
2. Run the `yarn generate-icons` command to generate the React component files. The components are generated using the `svgo` CLI and the template file `packages/components/icons/src/templates/icon.styles.tsx`.
2. Run the `yarn generate-icons` command to generate the React component files. The components are generated using the `svgr` CLI and the template file in `svgr/config.js`

## Adding changesets

Expand Down
137 changes: 8 additions & 129 deletions packages/components/icons/src/generated/AngleDownReact.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

137 changes: 8 additions & 129 deletions packages/components/icons/src/generated/AngleLeftReact.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading