Fct 1311 - icons bundle 2 #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronDWall
requested review from
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford and
misama-ct
and removed request for
a team
🦋 Changeset detectedLatest commit: 05e1e9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 98 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
jaikamat
approved these changes
Dec 10, 2024
tylermorrisford
approved these changes
Dec 10, 2024
tdeekens
approved these changes
Dec 11, 2024
tdeekens
reviewed
Dec 13, 2024
| echo "Ignoring PR because of the branch name. Exiting workflow." | ||
| exit 1 | ||
| fi | ||
| # - name: Validate branch name |
There was a problem hiding this comment.
yes, although it should be updated/fixed in another PR
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "main": "dist/commercetools-uikit-icons-generated-ImportReact.cjs.js", | |||
There was a problem hiding this comment.
Should we kebab case the package name part which is the icon?
There was a problem hiding this comment.
everything in packages/icons/generated is auto-generated by preconstruct when you run preconstruct dev or preconstruct build, and there is no way to configure the naming format in preconstruct.
|
Sorry for re-reviewing. Disregard. Just things that appear to the eye when reviewing thrice ;) |
ByronDWall
commented
Dec 13, 2024
| @@ -22,10 +22,17 @@ | |||
| "./index.ts", | |||
| "./custom-icon/index.ts", | |||
| "./inline-svg/index.ts", | |||
| "./leading-icon/index.ts" | |||
| "./leading-icon/index.ts", | |||
| "./generated/*.tsx" | |||
There was a problem hiding this comment.
This glob tells preconstruct that each of the icons should have an entrypoint in the package.
ByronDWall
commented
Dec 13, 2024
| "custom-icon", | ||
| "inline-svg", | ||
| "leading-icon", | ||
| "generated/**" |
There was a problem hiding this comment.
This glob tells preconstruct that we expect the dist/package.json for each icon to be in the generated folder.
ByronDWall
commented
Dec 13, 2024
ByronDWall
force-pushed
the
FCT-1311-icons-bundle-2
branch
from
179c258 to
05e1e9c
Compare
… remove unnecessary styling boilerplate from icons template
…ls-ui-kit/icons namespace, remove unnecessary pure annotations from icon template in svgr.config.js, add CONTRIBUTING.md file explaining how to add/update/remove icons in ui kit
…add preview branch name check back into preview-release github workflow
…o @commercetools-uikit/icons for backwards compatibility reasons
ByronDWall
force-pushed
the
FCT-1311-icons-bundle-2
branch
from
05e1e9c to
8615362
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SVGR template for generating icons, results in a substantial reduction in bundle size for ui kit icons, as shown in screenshots.
Implements a unique entrypoint for each icon, which enables better tree shaking in consuming applications. This results in a substantial decrease in bundle size for consuming applications, since they can bundle only necessary icons, as shown in the third screenshot.
From 1.35MB to 287kb unzipped, from 341kb to 201kb parsed, from 46kb to 38kb gzipped.
Previous:
Without unique entrypoints:
WITH UNIQUE ENTRYPOINTS FOR EACH ICON:
