Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor default props in preparations for react v8 migration #3016

Closed

Conversation

ddouglasz
Copy link
Contributor

@ddouglasz ddouglasz commented Dec 11, 2024

Summary

Refactor default props in preparations for react a8 migration

Description

This pull request includes significant changes to the handling of default props in various components. The changes focus on removing the defaultProps static property and replacing it with default inline parameter values in function and arrow function components. This is in preparation for the react18 migration.

Some key notes,
This PR changes were made mostly using a codemod to help modify repetitive code.

Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 493374a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 11:07pm

@ddouglasz ddouglasz added the fe-chapter-rotation Tasks coming from frontend chapter work label Dec 11, 2024
@ddouglasz ddouglasz changed the title Default props cleanup in preparations for react a8 migration Refactor default props in preparations for react a8 migration Dec 12, 2024
@CarlosCortizasCT CarlosCortizasCT changed the title Refactor default props in preparations for react a8 migration Refactor default props in preparations for react v8 migration Dec 12, 2024
@CarlosCortizasCT
Copy link
Contributor

I've opened a new PR for adjusting the usages of the defaultProps based on the codemod implemented in app-kit (reference) so I think we can close this one.

@CarlosCortizasCT
Copy link
Contributor

Closing as this was superseeded by #3027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-chapter-rotation Tasks coming from frontend chapter work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants