Fix tests for upgrade_document

[tom-tan]

This request fixes tests that were added by #79 (introduced by me :-( ).
They should check the upgraded document and the expected document but they do not in the current implementation.

I also change _v1_0_to_v1_1 to add LoadListingRequirement and NetworkAccess to requirements rather than hints not to break the behavior of given CWL documents. See listing_deep1.cwl for example.

[codecov]

Codecov Report

Merging #85 (259a622) into main (e2a05df) will increase coverage by 3.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   72.27%   75.51%   +3.23%     
==========================================
  Files           4        4              
  Lines         523      535      +12     
==========================================
+ Hits          378      404      +26     
+ Misses        145      131      -14     

Impacted Files	Coverage Δ
cwlupgrader/main.py	72.42% <100.00%> (+2.94%)	⬆️
tests/test_complete.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a05df...259a622. Read the comment docs.

[mr-c]

This request fixes tests that were added by #79 (introduced by me :-( ). They should check the upgraded document and the expected document but they do not in the current implementation.

👍👍

I also change _v1_0_to_v1_1 to add LoadListingRequirement and NetworkAccess to requirements rather than hints not to break the behavior of given CWL documents. See listing_deep1.cwl for example.

Interesting. This does not match the behavior of the reference runner. https://github.com/common-workflow-language/cwltool/blob/352daf6d53f12df4cd960c0343ef659924aa9712/cwltool/update.py#L127

@tetron Do you remember why we put these as hints instead of requirements?

[mr-c]

A couple lines without test coverage.

[tom-tan]

ping!

[mr-c]

LGTM, but @tetron needs to share his opinion about adding LoadListingRequirement and NetworkAccess to reqs instead of hints when upgrading v1.0 → v1.1

[mr-c]

@tom-tan , Peter says "sure" :-)

https://matrix.to/#/!RQMxrGNGkeDmWHOaEs:gitter.im/$2uVLM10OOgig25VMO8ZY2kAEQaiI05nYKW1ijblsC2Y