ArraySchema.items is also TypeDSL #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Othwerwise the codegen code doesn't allow refering to arrays of custom types
Codecov Report
@@ Coverage Diff @@
## main #429 +/- ##
=======================================
Coverage 79.49% 79.49%
=======================================
Files 18 18
Lines 3268 3268
Branches 880 880
=======================================
Hits 2598 2598
Misses 438 438
Partials 232 232 Continue to review full report at Codecov.
|
mr-c
added a commit
to common-workflow-language/cwl-v1.1
that referenced
this pull request
Sep 4, 2021
mr-c
added a commit
to common-workflow-language/cwl-v1.1
that referenced
this pull request
Sep 4, 2021
And other small fixes As of common-workflow-language/schema_salad#429 a.k.a common-workflow-language/schema_salad@5fccc55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Othwerwise the codegen code doesn't allow refering to arrays of custom types
Part of the fix for common-workflow-language/cwl-utils#71 & will fix (after another PR there) common-workflow-language/cwl-utils#93