feat: Add a User Agent to cc-downloader #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a User Agent to cc-downloader so that its use can better be tracked. It adds a refactor to the way the client is built so that the code is reused by both the download-paths and download functions. It also adds 2 tests to check that the user agent is properly set.
|
LGTM. Thanks @pjox! I would hasten to add to the description of this PR that it's not so much that its use can better be tracked, but it's so that it uses proper HTTP semantics to conform with RFC 9110. |
thunderpoot
approved these changes
Feb 4, 2025
pjox
added a commit
that referenced
this pull request
Feb 15, 2025
chore: Merges fixes, features and refactors for version 0.5.2 Fixes issue feat: Add a User Agent to cc-downloader #6 - Introduces refactors so that linter check are all passed - Introduces a rust workflow for ensuring that the code compiles and test are passed in the dev and main branches - Introduces changes to the contributing policy so that PRs are merged to the dev branch - Introduces slight updates to the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a User Agent to cc-downloader so that its use can better be tracked.
It adds a refactor to the way the client is built so that the code is reused by both the download-paths and download functions.
It also adds 2 tests to check that the user agent is properly set.