Skip to content

Commit

Permalink
Generic split test class so we can do other ones quickly (test deploy)
Browse files Browse the repository at this point in the history
  • Loading branch information
janbaykara committed Jan 29, 2024
1 parent 200c20f commit 106bc2a
Showing 1 changed file with 18 additions and 6 deletions.
24 changes: 18 additions & 6 deletions app/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -1024,20 +1024,32 @@ def get_context_data(self, **kwargs):
return context


class CreateMembershipView(SelectReadingSpeedView):
class AnonymousUserSplitTest(View):
feature_flag: str
variant_path_mapping: Dict[str, str]
default_path: str

def get(self, request: HttpRequest, *args: str, **kwargs: Any) -> HttpResponse:
# Because sometimes the session hasn't been initialised
# https://stackoverflow.com/a/39188274/1053937
if not request.session.session_key:
request.session.save()

user_id = request.session.session_key
enabled_variant = posthog.get_feature_flag("new-signup-flow", user_id)
enabled_variant = posthog.get_feature_flag(self.feature_flag, user_id)

if enabled_variant == "v2":
return redirect("signup_reading_speed")
else:
return redirect("/join")
# self.variant_path_mapping
for variant in self.variant_path_mapping.keys():
if enabled_variant == variant:
return redirect(self.variant_path_mapping[variant])

return redirect(self.default_path)


class CreateMembershipView(AnonymousUserSplitTest):
feature_flag = "new-signup-flow"
variant_path_mapping = {"v1": "signup", "v2": "signup_reading_speed"}
default_path = "signup"


class SelectSyllabusView(OneAtATimeFormViewStoredToSession):
Expand Down

0 comments on commit 106bc2a

Please sign in to comment.