Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various copy changes #146

Merged
merged 12 commits into from
Dec 10, 2024
Merged

Various copy changes #146

merged 12 commits into from
Dec 10, 2024

Conversation

Moggach
Copy link

@Moggach Moggach commented Dec 5, 2024

Description

This PR includes

  • replacing CRM in the UI with the specific CRM type name
  • Generating a link to the user's Action Network API keys from their inputted group slug
  • Standardising and making UI labels and explanation text clearer

Motivation and Context

Addresses issues MAP-313,, MAP-436 and MAP-316

How Can It Be Tested?

Download the branch and run locally
Run through the on-boarding process for as many CRM types as you like but make sure you include Action Network
Observe the new copy and UI labels
Observe that we generate for the user a URL to their Action Network API keys

How Will This Be Deployed?

Normal CD process

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Moggach added 11 commits December 2, 2024 16:37
@Moggach
generate link to action network api page settings from group slug and…
d0f6933 
… only show api key field once this link has been generated
@Moggach
add utility function to format CRM names before we render them
115f919
@Moggach
update CRM to specific data source name when we have it
4fad4da
@Moggach
two more instances of update CRM to specific data source name when we…
ebae1a4 
… have it
@Moggach
merge latest from main
109b32e
@Moggach
update capitalise words function with format CRM function - using swi…
7c0ad67 
…tch statement to account for CRM names that are one word strings
@Moggach
correct the actionNetworkApiUrl link
ed63da9
@Moggach
change data layers to data sources in new external data onboarding
042e718
@Moggach
put specific CRM name into trigger update button
b435c78
@Moggach
change membership data sources header to membership lists
e52c0f8
@Moggach
git commit -m update generic CRM with specific CRM type where possible
8cf0de3
janbaykara
janbaykara requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@janbaykara janbaykara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the default "CRM", shall we instead use "database"?

@Moggach
Copy link
Author

Moggach commented Dec 9, 2024

For the default "CRM", shall we instead use "database"?

yep, will make that change

ev-sc
ev-sc approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@ev-sc ev-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-sc ev-sc requested a review from janbaykara December 9, 2024 13:29
@Moggach Moggach merged commit 78f6367 into main Dec 10, 2024
4 checks passed
@Moggach Moggach deleted the various-copy-changes branch December 10, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-sc ev-sc ev-sc approved these changes

@joaquimds joaquimds Awaiting requested review from joaquimds

@janbaykara janbaykara Awaiting requested review from janbaykara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moggach @janbaykara @ev-sc