forked from mysociety/local-intelligence-hub
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds runworker command that will restart the worker on code changes #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55d73e3
to
7b64355
Compare
7b64355
to
1d45ead
Compare
ev-sc
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works! Amazing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the command, and updates the run configuration to use this instead of the underlying
procrastinate worker
command.Motivation and Context
When developing Mapped, it's very annoying to have to remember to restart the worker when changing background job code.
How Can It Be Tested?
Launching a worker on all queues
)procrastinate.worker
inlocal_intelligence_hub/settings.py
fromINFO
toDEBUG
(or vice versa)DEBUG
, there should beprocrastinate.worker.wait_for_job:172 # Waiting for new jobs on all queues
log statements. If the log level isINFO
, there should not be.You can also check that breakpoints work in the job functions, e.g.
deferred_import_many
.