Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds runworker command that will restart the worker on code changes #153

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

joaquimds
Copy link

Description

Adds the command, and updates the run configuration to use this instead of the underlying procrastinate worker command.

Motivation and Context

When developing Mapped, it's very annoying to have to remember to restart the worker when changing background job code.

How Can It Be Tested?

  1. Start the run configuration "Django background worker" (or "Run Mapped!")
  2. Wait for the worker to start up (Launching a worker on all queues)
  3. Toggle the log level of procrastinate.worker in local_intelligence_hub/settings.py from INFO to DEBUG (or vice versa)
  4. Observe that the worker restarts. If the log level is DEBUG, there should be procrastinate.worker.wait_for_job:172 # Waiting for new jobs on all queues log statements. If the log level is INFO, there should not be.

You can also check that breakpoints work in the job functions, e.g. deferred_import_many.

@commonknowledge-bot commonknowledge-bot deployed to feat/dev-worker-restart - meep-database PR #153 December 10, 2024 17:52 — with Render Active
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/dev-worker-restart - meep-intelligence-hub-backend PR #153 December 10, 2024 17:53 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/dev-worker-restart - meep-intelligence-hub-backend PR #153 December 10, 2024 17:53 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/dev-worker-restart - meep-intelligence-hub-frontend PR #153 December 10, 2024 17:53 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot had a problem deploying to feat/dev-worker-restart - meep-intelligence-hub-worker PR #153 December 10, 2024 17:53 — with Render Failure
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/dev-worker-restart - meep-intelligence-hub-frontend PR #153 December 10, 2024 17:53 — with Render Destroyed
@joaquimds joaquimds force-pushed the feat/dev-worker-restart branch from 55d73e3 to 7b64355 Compare December 10, 2024 18:02
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/dev-worker-restart - meep-intelligence-hub-backend PR #153 December 10, 2024 18:02 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/dev-worker-restart - meep-intelligence-hub-worker PR #153 December 10, 2024 18:02 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot deployed to feat/dev-worker-restart - meep-intelligence-hub-worker PR #153 December 11, 2024 09:45 — with Render Active
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/dev-worker-restart - meep-intelligence-hub-backend PR #153 December 11, 2024 09:45 — with Render Destroyed
Copy link
Member

@ev-sc ev-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works! Amazing

@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/dev-worker-restart - meep-intelligence-hub-worker PR #153 December 11, 2024 09:48 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/dev-worker-restart - meep-intelligence-hub-backend PR #153 December 11, 2024 09:48 — with Render Destroyed
@ev-sc ev-sc merged commit d18e7c8 into main Dec 11, 2024
2 of 4 checks passed
@ev-sc ev-sc deleted the feat/dev-worker-restart branch December 11, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants