forked from mysociety/local-intelligence-hub
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the UI for importing and enriching data [MAP-347] [MAP-78] [MAP-77] #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… statuses of to do or doing and add it to graphql query for use in front end
…alDataSource model for use in updating progress bar in UI
…b and imported message is aligned left
…y and make progress bar component display even when job is not in progress
…_progress method and update BatchJobProgress types
…bjects in ExternalDataSourceInspectPage and display it in the UI
… longer than a certain time threshold
…a message in the UI when a job will take more than 5 minutes
commonknowledge-bot
deployed
to
improvements-to-import-enrich-data-ui - meep-database PR #154
December 10, 2024 18:53 — with
Render
Active
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-backend PR #154
December 10, 2024 18:54 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-backend PR #154
December 10, 2024 18:55 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-frontend PR #154
December 10, 2024 18:55 — with
Render
Destroyed
commonknowledge-bot
deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-worker PR #154
December 10, 2024 18:55 — with
Render
Active
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-worker PR #154
December 10, 2024 19:02 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-backend PR #154
December 10, 2024 19:02 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-backend PR #154
December 12, 2024 17:51 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-worker PR #154
December 12, 2024 17:51 — with
Render
Destroyed
I've refactored the timing check to use estimated time only as we need to make the decision before the job is finished |
janbaykara
changed the title
Improvements to the UI for importing and enriching data
Improvements to the UI for importing and enriching data [MAP-347]
Dec 12, 2024
janbaykara
changed the title
Improvements to the UI for importing and enriching data [MAP-347]
Improvements to the UI for importing and enriching data [MAP-347] [MAP-78]
Dec 12, 2024
OK. I think early next week @joaquimds or I just need to test this robustly, fix whatever's required and then merge. It might be right as rain already though, looking good @Moggach! |
janbaykara
changed the title
Improvements to the UI for importing and enriching data [MAP-347] [MAP-78]
Improvements to the UI for importing and enriching data [MAP-347] [MAP-78] [MAP-77]
Dec 12, 2024
commonknowledge-bot
deployed
to
improvements-to-import-enrich-data-ui - meep-database PR #154
December 16, 2024 13:02 — with
Render
Active
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-backend PR #154
December 16, 2024 13:02 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-backend PR #154
December 16, 2024 13:02 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-frontend PR #154
December 16, 2024 13:02 — with
Render
Destroyed
commonknowledge-bot
had a problem deploying
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-worker PR #154
December 16, 2024 13:02 — with
Render
Failure
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-frontend PR #154
December 16, 2024 13:02 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-backend PR #154
December 16, 2024 13:11 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
improvements-to-import-enrich-data-ui - meep-intelligence-hub-worker PR #154
December 16, 2024 13:11 — with
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds:
if an import or update is in a queue behind others indicate this in the UI
a progress bar when importing and updating records
when an job is going to take longer than 5 minutes tell the user it is finished via email
Motivation and Context
Addresses issues MAP-347,, MAP-77, MAP-78
How Can It Be Tested?
Run the branch locally
Import and/or update a data source
Testing progress bar:
Testing job queue:
Testing email notification: