forked from mysociety/local-intelligence-hub
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate phone number when importing external data [MAP-631] [MAP-77] #159
Merged
janbaykara
merged 18 commits into
main
from
feat/disable-call-sms-buttons-if-phone-number-invalid
Dec 12, 2024
Merged
Validate phone number when importing external data [MAP-631] [MAP-77] #159
janbaykara
merged 18 commits into
main
from
feat/disable-call-sms-buttons-if-phone-number-invalid
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonknowledge-bot
deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-database PR #159
December 11, 2024 15:42 — with
Render
Active
commonknowledge-bot
temporarily deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-backend PR #159
December 11, 2024 15:42 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-backend PR #159
December 11, 2024 15:43 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-frontend PR #159
December 11, 2024 15:43 — with
Render
Destroyed
commonknowledge-bot
deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-worker PR #159
December 11, 2024 15:43 — with
Render
Active
commonknowledge-bot
deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-worker PR #159
December 11, 2024 15:58 — with
Render
Active
commonknowledge-bot
deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-worker PR #159
December 11, 2024 16:12 — with
Render
Active
…od and save method of GenericData class
commonknowledge-bot
temporarily deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-backend PR #159
December 12, 2024 13:02 — with
Render
Destroyed
commonknowledge-bot
deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-worker PR #159
December 12, 2024 13:03 — with
Render
Active
commonknowledge-bot
temporarily deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-backend PR #159
December 12, 2024 16:12 — with
Render
Destroyed
commonknowledge-bot
deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-worker PR #159
December 12, 2024 16:13 — with
Render
Active
commonknowledge-bot
had a problem deploying
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-worker PR #159
December 12, 2024 17:30 — with
Render
Failure
commonknowledge-bot
had a problem deploying
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-worker PR #159
December 12, 2024 18:02 — with
Render
Failure
janbaykara
force-pushed
the
feat/disable-call-sms-buttons-if-phone-number-invalid
branch
from
December 12, 2024 18:07
501bcdd
to
89f5764
Compare
commonknowledge-bot
temporarily deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-backend PR #159
December 12, 2024 18:07 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-worker PR #159
December 12, 2024 18:07 — with
Render
Destroyed
janbaykara
changed the title
Validate phone number when importing external data
Validate phone number when importing external data [MAP-631]
Dec 12, 2024
janbaykara
deleted the
feat/disable-call-sms-buttons-if-phone-number-invalid
branch
December 12, 2024 21:44
janbaykara
changed the title
Validate phone number when importing external data [MAP-631]
Validate phone number when importing external data [MAP-631] [MAP-77]
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR validates phone numbers when an external data source is imported or updated
If phone number is not a valid UK number it imports/updates the value as None
Motivation and Context
Addresses issue MAP-631
How Can It Be Tested?
console.log(selectedPointData, 'selected point data')
to the MarkerPopup component and observe the way the data is changed