Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate phone number when importing external data [MAP-631] [MAP-77] #159

Merged
merged 18 commits into from
Dec 12, 2024

Conversation

Moggach
Copy link

@Moggach Moggach commented Dec 11, 2024

Description

This PR validates phone numbers when an external data source is imported or updated
If phone number is not a valid UK number it imports/updates the value as None

Motivation and Context

Addresses issue MAP-631

How Can It Be Tested?

  1. Run the branch locally
  2. Import a data source with a mixture of valid and invalid values in phone number field
  3. Select People for Type of Data Source
  4. Make sure to map the phone number field in the data source with Phone Field in Mapped
  5. Load the data source onto a Map
  6. Observe that only valid phone numbers have a call or SMS option
  7. If you like add console.log(selectedPointData, 'selected point data') to the MarkerPopup component and observe the way the data is changed

Untitled

@commonknowledge-bot commonknowledge-bot deployed to feat/disable-call-sms-buttons-if-phone-number-invalid - meep-database PR #159 December 11, 2024 15:42 — with Render Active
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-backend PR #159 December 11, 2024 15:42 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-backend PR #159 December 11, 2024 15:43 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-frontend PR #159 December 11, 2024 15:43 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot deployed to feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-worker PR #159 December 11, 2024 15:43 — with Render Active
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-backend PR #159 December 12, 2024 13:02 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot deployed to feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-worker PR #159 December 12, 2024 13:03 — with Render Active
@Moggach Moggach requested review from janbaykara and ev-sc December 12, 2024 13:09
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-backend PR #159 December 12, 2024 16:12 — with Render Destroyed
@janbaykara janbaykara force-pushed the feat/disable-call-sms-buttons-if-phone-number-invalid branch from 501bcdd to 89f5764 Compare December 12, 2024 18:07
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-backend PR #159 December 12, 2024 18:07 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to feat/disable-call-sms-buttons-if-phone-number-invalid - meep-intelligence-hub-worker PR #159 December 12, 2024 18:07 — with Render Destroyed
@janbaykara janbaykara changed the title Validate phone number when importing external data Validate phone number when importing external data [MAP-631] Dec 12, 2024
Copy link

linear bot commented Dec 12, 2024

@janbaykara janbaykara merged commit e4a7f7d into main Dec 12, 2024
4 checks passed
@janbaykara janbaykara deleted the feat/disable-call-sms-buttons-if-phone-number-invalid branch December 12, 2024 21:44
@janbaykara janbaykara changed the title Validate phone number when importing external data [MAP-631] Validate phone number when importing external data [MAP-631] [MAP-77] Dec 12, 2024
Copy link

linear bot commented Dec 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants