forked from mysociety/local-intelligence-hub
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generate a map button to inspect external data source page #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in InspectExternalDataSource
…of display options back to the frontend pre-loaded
…ource inspect page
…report already exists for this data source and returns link to that report in error
commonknowledge-bot
deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-database PR #161
December 16, 2024 12:54 — with
Render
Active
commonknowledge-bot
temporarily deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-backend PR #161
December 16, 2024 12:55 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-backend PR #161
December 16, 2024 12:55 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-frontend PR #161
December 16, 2024 12:55 — with
Render
Destroyed
commonknowledge-bot
deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-worker PR #161
December 16, 2024 12:55 — with
Render
Active
joaquimds
approved these changes
Dec 16, 2024
commonknowledge-bot
temporarily deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-backend PR #161
December 16, 2024 17:07 — with
Render
Destroyed
commonknowledge-bot
deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-worker PR #161
December 16, 2024 17:07 — with
Render
Active
commonknowledge-bot
temporarily deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-backend PR #161
December 16, 2024 17:12 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-worker PR #161
December 16, 2024 17:13 — with
Render
Destroyed
commonknowledge-bot
had a problem deploying
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-worker PR #161
December 16, 2024 17:13 — with
Render
Failure
commonknowledge-bot
temporarily deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-frontend PR #161
December 16, 2024 17:13 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-frontend PR #161
December 16, 2024 17:13 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-worker PR #161
December 16, 2024 17:17 — with
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/MAP-354-add-view-this-on-report-button - meep-intelligence-hub-backend PR #161
December 16, 2024 17:18 — with
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following:
A generate map for this data source button on the inspect external data source page that loads the data source onto a map and redirects the user to it
A check so that if a map with this data source already exists we provide a link to that map
Motivation and Context
Addresses issue MAP-354
How Can It Be Tested?
Download the branch and run locally
Import an external data source
Click on the Generate map for this data source button and observe that it redirects to a map with this data source loaded
Try to click on the button a second time and observe that the toast message offers a link to the existing map
How Will This Be Deployed?
Normal deployment process