Allow choropleth to be toggled on and off #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonknowledge-bot
deployed
to
feature/map-711-toggle-choropleth-on-off - meep-database PR #168
Render
Active
commonknowledge-bot
temporarily deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-backend PR #168
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-backend PR #168
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-frontend PR #168
Render
Destroyed
commonknowledge-bot
deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-worker PR #168
Render
Active
joaquimds
reviewed
Dec 18, 2024
nextjs/src/app/reports/[id]/(components)/MapLayers/PoliticalChoropleths.tsx
Outdated
Show resolved
Hide resolved
…wDataVisualisation property to dataVisualisation in ReportConfig
…edTypes state with the current checked value
…nent and show choropleth fill if it is true
commonknowledge-bot
temporarily deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-frontend PR #168
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-frontend PR #168
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-backend PR #168
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-backend PR #168
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-backend PR #168
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-worker PR #168
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-worker PR #168
Render
Destroyed
janbaykara
requested changes
Dec 18, 2024
Comment on lines
80
to
95
| {showChoropleth && ( | ||
| <> | ||
| <Layer | ||
| beforeId="road-simple" | ||
| id={`${tileset.mapboxSourceId}-fill`} | ||
| source={tileset.mapboxSourceId} | ||
| source-layer={tileset.sourceLayerId} | ||
| type="fill" | ||
| filter={getChoroplethFillFilter(dataByBoundary, tileset)} | ||
| paint={getChoroplethFill( | ||
| dataByBoundary, | ||
| visibility === 'visible' | ||
| )} | ||
| /> | ||
| </> | ||
| )} |
There was a problem hiding this comment.
This will change the layer order in ways that might break the visualisation.
There is already a const visibility statement further up. Let's just add an extra condition into that instead.
commonknowledge-bot
temporarily deployed
to
feature/map-711-toggle-choropleth-on-off - meep-intelligence-hub-frontend PR #168
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to select None in the Type dropdown in the Data Visualisation section to turn off the choropleth
Motivation and Context
Addresses issue MAP-711
How Can It Be Tested?
Download the branch and run locally
Create a map or navigate to an existing one
Go to configuration tab and select None under Type in Data Visualisation
Observe that selecting None turns off the choropleth (and reselecting Chropleth toggles it back on again)