feat: add postgis geocoder as a postcodes.io replacement #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonknowledge-bot
deployed
to
feat/postgis-geocoding - meep-database PR #211
Render
Active
commonknowledge-bot
temporarily deployed
to
feat/postgis-geocoding - meep-intelligence-hub-backend PR #211
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/postgis-geocoding - meep-intelligence-hub-backend PR #211
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/postgis-geocoding - meep-intelligence-hub-frontend PR #211
Render
Destroyed
commonknowledge-bot
had a problem deploying
to
feat/postgis-geocoding - meep-intelligence-hub-worker PR #211
Render
Failure
commonknowledge-bot
had a problem deploying
to
feat/postgis-geocoding - meep-intelligence-hub-worker PR #211
Render
Failure
commonknowledge-bot
had a problem deploying
to
feat/postgis-geocoding - meep-intelligence-hub-worker PR #211
Render
Failure
commonknowledge-bot
had a problem deploying
to
feat/postgis-geocoding - meep-intelligence-hub-worker PR #211
Render
Failure
janbaykara
approved these changes
Feb 7, 2025
hub/data_imports/geocoding_config.py
Outdated
Comment on lines
262
to
265
| if literal_lih_area_type__code: | ||
| area_filters["area_type__code"] = literal_lih_area_type__code | ||
| if literal_mapit_type: | ||
| area_filters["mapit_type"] = literal_mapit_type | ||
| area_filters["mapit_type__in"] = literal_mapit_type |
There was a problem hiding this comment.
Do we need to ensure_list() on mapit_type__in and also listify the area_type__code conditional, just above?
commonknowledge-bot
had a problem deploying
to
feat/postgis-geocoding - meep-intelligence-hub-worker PR #211
Render
Failure
commonknowledge-bot
temporarily deployed
to
feat/postgis-geocoding - meep-intelligence-hub-frontend PR #211
Render
Destroyed
commonknowledge-bot
had a problem deploying
to
feat/postgis-geocoding - meep-intelligence-hub-worker PR #211
Render
Failure
commonknowledge-bot
had a problem deploying
to
feat/postgis-geocoding - meep-intelligence-hub-worker PR #211
Render
Failure
commonknowledge-bot
temporarily deployed
to
feat/postgis-geocoding - meep-intelligence-hub-backend PR #211
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/postgis-geocoding - meep-intelligence-hub-worker PR #211
Render
Destroyed
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new geocoding dataloader that uses PostGIS queries on our database to provide postcodes.io functionality.
Motivation and Context
Improves import performance.
How Can It Be Tested?
Import an area_stats dataset and check the worker logs to make sure the postgis_geocoder is running.